-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the performance of the keyboard shortcuts binding #23394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Performance
Related to performance efforts
[Type] Code Quality
Issues or PRs that relate to code quality
labels
Jun 23, 2020
youknowriad
requested review from
ajitbohra,
ellatrix,
etoledom and
SergioEstevao
as code owners
June 23, 2020 14:05
Size Change: -70 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
update/keyboard-shortcut
branch
from
June 26, 2020 10:57
c88ab65
to
78a4358
Compare
1 task
github-actions
bot
added
the
[Status] In Progress
Tracking issues with work in progress
label
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Status] In Progress
Tracking issues with work in progress
[Type] Code Quality
Issues or PRs that relate to code quality
[Type] Performance
Related to performance efforts
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to improve the keyboard shortcuts components performance by avoiding to map the keyboard shortcuts on each render (onUse change).
Not sure this has a direct impact on performance but it's a better implementation regardless.