-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image editing: preserve crop position through rotations #23374
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +354 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
fix/image-editing-order
branch
from
June 23, 2020 08:12
5745faa
to
d0c403d
Compare
ellatrix
changed the title
Image editing: fix edit order
Image editing: fix crop when applied before rotation
Jun 23, 2020
ellatrix
changed the title
Image editing: fix crop when applied before rotation
Image editing: preserve crop position through rotations
Jun 23, 2020
noisysocks
pushed a commit
that referenced
this pull request
Jun 24, 2020
* Image editing: fix edit order * Adjust position after rotation * Update natural aspect ratio after rotation
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #23284, I didn't update the crop position x and y values after rotating on client side. I also messed up the order in which edits should be applied. On the client side, the crop is applied on top of the rotation, which should be the same on the server side.
How has this been tested?
Screenshots
Types of changes
Checklist: