Add new command for pre-releasing npm packages #23357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
gziolo
reviewed
Jun 24, 2020
bin/plugin/commands/packages.js
Outdated
| versionBump !== null | ||
| ? semver.inc( version, versionBump ) | ||
| : null; | ||
|
|
||
| if ( nextVersion !== null && isRC ) { |
There was a problem hiding this comment.
We can’t use the actual release number because Lerna uses npm version command internally that always has to bump version but we could use -pre.1 suffix that we could simply update to the final version when the actual publishing happens. I didn’t think about it earlier. Great idea, thanks ❤️
So, we would need two versions, one for the changelog and one for package.json.
gziolo
force-pushed
the
add/npm-rc-command
branch
from
241ab13 to
ea26c91
Compare
gziolo
added
[Package] Project management automation
gziolo
force-pushed
the
add/npm-rc-command
branch
from
ac618af to
6785d3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explore adding a new command
npm-rcto release npm packages to thenexttag as pre-release.TODO: