BlockSettingsMenuControlsSlot: add missing useSelect dependency. #23247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZebulanStanphill
added
[Type] Bug
|
Size Change: -3 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
ZebulanStanphill
added
the
Good First Review
youknowriad
approved these changes
Jun 18, 2020
|
Rebase and merge maybe? |
|
Yeah, assuming the React Native tests don't crash again (which seems to be the most common issue I keep running into with the end-to-end tests right now), rebasing should get the tests passing. |
ZebulanStanphill
force-pushed
the
fix/block-settings-menu-controls-slot-use-select-dependencies
branch
from
c3e74d4 to
326849a
Compare
Yes, we should expect some failures on the next days as they just merged the native repo here. let's just keep them informed about the failures so they can work on them. |
ZebulanStanphill
force-pushed
the
fix/block-settings-menu-controls-slot-use-select-dependencies
branch
from
326849a to
2298d17
Compare
ZebulanStanphill
deleted the
fix/block-settings-menu-controls-slot-use-select-dependencies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a missing dependency to the
useSelectcall in theBlockSettingsMenuControlsSlotcomponent. This might fix some obscure bugs, but even if not, it's still a good idea to harden this code against potential future bugs by making this change.