Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix $theme-color error in Template Part block #23221

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

Addison-Stavlo
Copy link
Contributor

@Addison-Stavlo Addison-Stavlo commented Jun 16, 2020

Description

Fix build error coming from $theme-color as noted #22760 (comment) and issue #23217.

In the time between passing builds and merging #22760, it looks like we got rid of the last instance of $theme-color in the repo and replaced it with var(--wp-admin-theme-color) in #23048.

How has this been tested?

Screenshots

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@epiqueras epiqueras merged commit 7433677 into master Jun 16, 2020
@epiqueras epiqueras deleted the fix/template-part-theme-color-error branch June 16, 2020 21:32
@github-actions github-actions bot added this to the Gutenberg 8.4 milestone Jun 16, 2020
@Addison-Stavlo Addison-Stavlo self-assigned this Jun 16, 2020
This was referenced Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants