Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding cross-env when setting env var in fixtures:generate #2318

Merged
merged 1 commit into from
Aug 9, 2017

Conversation

BE-Webdesign
Copy link
Contributor

Adding cross-env to the fixtures generate script so these scripts can be
run cross platform. When setting environment vars let's always use cross-env.

Adding cross-env to the fixtures generate script so these scripts can be
run cross platform.
@codecov
Copy link

codecov bot commented Aug 9, 2017

Codecov Report

Merging #2318 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2318      +/-   ##
==========================================
+ Coverage   25.37%   25.47%   +0.09%     
==========================================
  Files         151      151              
  Lines        4705     4758      +53     
  Branches      792      804      +12     
==========================================
+ Hits         1194     1212      +18     
- Misses       2969     2999      +30     
- Partials      542      547       +5
Impacted Files Coverage Δ
editor/effects.js 32.52% <0%> (+1.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8d0ca4...a8368a2. Read the comment docs.

Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@BE-Webdesign BE-Webdesign merged commit c8a35d4 into master Aug 9, 2017
Copy link
Member

@ntwb ntwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up 👍

@ntwb ntwb deleted the update/always-use-cross-env branch August 10, 2017 04:19
ceyhun pushed a commit that referenced this pull request Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants