Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Navigation Block ] Renamed navigation link title to Link #23163

Merged
merged 2 commits into from
Jun 18, 2020

Conversation

draganescu
Copy link
Contributor

Description

Advances #22750

How has this been tested?

Tested locally by:

  • create a new post
  • add a navigation block
  • choose create empty
  • verify the appender says "Add Link"

Screenshots

Screenshot 2020-06-15 at 17 19 49

Types of changes

Updated the title of the Navigation Link block. It seems premature to rename the whole block before we decide it can be a standalone block.

@draganescu draganescu added [Type] Enhancement A suggestion for improvement. [Block] Navigation Affects the Navigation Block labels Jun 15, 2020
@github-actions
Copy link

github-actions bot commented Jun 15, 2020

Size Change: -6.67 kB (0%)

Total Size: 1.13 MB

Filename Size Change
build/annotations/index.js 3.62 kB -2 B (0%)
build/api-fetch/index.js 3.4 kB +1 B
build/block-directory/index.js 7.26 kB +47 B (0%)
build/block-directory/style-rtl.css 955 B +63 B (6%) 🔍
build/block-directory/style.css 955 B +63 B (6%) 🔍
build/block-editor/index.js 106 kB -94 B (0%)
build/block-editor/style-rtl.css 10.7 kB -1.39 kB (12%) 👏
build/block-editor/style.css 10.7 kB -1.39 kB (12%) 👏
build/block-library/editor-rtl.css 7.85 kB -32 B (0%)
build/block-library/editor.css 7.86 kB -30 B (0%)
build/block-library/index.js 129 kB +712 B (0%)
build/block-library/style-rtl.css 8.02 kB +65 B (0%)
build/block-library/style.css 8.02 kB +64 B (0%)
build/block-library/theme-rtl.css 749 B +65 B (8%) 🔍
build/block-library/theme.css 751 B +65 B (8%) 🔍
build/blocks/index.js 48.1 kB +5 B (0%)
build/components/index.js 196 kB +254 B (0%)
build/components/style-rtl.css 15.9 kB -3.59 kB (22%) 🎉
build/components/style.css 15.9 kB -3.6 kB (22%) 🎉
build/compose/index.js 9.6 kB +283 B (2%)
build/core-data/index.js 11.4 kB -1 B
build/data-controls/index.js 1.29 kB -3 B (0%)
build/data/index.js 8.44 kB -3 B (0%)
build/date/index.js 5.47 kB -2 B (0%)
build/dom-ready/index.js 569 B +1 B
build/dom/index.js 3.17 kB +1 B
build/edit-navigation/index.js 8.26 kB -2 B (0%)
build/edit-navigation/style-rtl.css 1.04 kB +64 B (6%) 🔍
build/edit-navigation/style.css 1.04 kB +66 B (6%) 🔍
build/edit-post/index.js 303 kB +874 B (0%)
build/edit-post/style-rtl.css 5.6 kB +4 B (0%)
build/edit-post/style.css 5.6 kB +5 B (0%)
build/edit-site/index.js 16.6 kB +8 B (0%)
build/edit-site/style-rtl.css 3.13 kB +173 B (5%) 🔍
build/edit-site/style.css 3.13 kB +173 B (5%) 🔍
build/edit-widgets/style-rtl.css 2.54 kB +133 B (5%) 🔍
build/edit-widgets/style.css 2.54 kB +132 B (5%) 🔍
build/editor/editor-styles-rtl.css 486 B +63 B (12%) ⚠️
build/editor/editor-styles.css 487 B +64 B (13%) ⚠️
build/editor/index.js 44.8 kB +61 B (0%)
build/editor/style-rtl.css 3.82 kB -444 B (11%) 👏
build/editor/style.css 3.82 kB -444 B (11%) 👏
build/element/index.js 4.65 kB +3 B (0%)
build/format-library/index.js 7.72 kB -2 B (0%)
build/format-library/style-rtl.css 561 B +59 B (10%) ⚠️
build/format-library/style.css 562 B +60 B (10%) ⚠️
build/hooks/index.js 2.13 kB -1 B
build/i18n/index.js 3.56 kB +1 B
build/is-shallow-equal/index.js 711 B +1 B
build/keyboard-shortcuts/index.js 2.51 kB +1 B
build/keycodes/index.js 1.94 kB -2 B (0%)
build/list-reusable-blocks/index.js 3.12 kB -4 B (0%)
build/list-reusable-blocks/style-rtl.css 537 B +311 B (57%) 🆘
build/list-reusable-blocks/style.css 537 B +311 B (57%) 🆘
build/media-utils/index.js 5.29 kB +3 B (0%)
build/notices/index.js 1.79 kB -4 B (0%)
build/nux/index.js 3.4 kB +2 B (0%)
build/nux/style-rtl.css 681 B +65 B (9%) 🔍
build/nux/style.css 676 B +63 B (9%) 🔍
build/priority-queue/index.js 788 B -1 B
build/redux-routine/index.js 2.85 kB +2 B (0%)
build/rich-text/index.js 14 kB -9 B (0%)
build/url/index.js 4.06 kB +1 B
build/viewport/index.js 1.85 kB -1 B
build/warning/index.js 1.14 kB -1 B
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/autop/index.js 2.83 kB 0 B
build/blob/index.js 620 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/deprecated/index.js 772 B 0 B
build/edit-widgets/index.js 9.34 kB 0 B
build/escape-html/index.js 733 B 0 B
build/html-entities/index.js 622 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.5 kB 0 B
build/server-side-render/index.js 2.68 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.28 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some legit test failures due to tests that depend on the old name. Should be pretty easy to update those and merge this.

@draganescu draganescu requested review from nerrad and ntwb as code owners June 17, 2020 16:31
@draganescu draganescu merged commit 9936625 into master Jun 18, 2020
@draganescu draganescu deleted the fix/rename-navigation-link branch June 18, 2020 11:06
@github-actions github-actions bot added this to the Gutenberg 8.4 milestone Jun 18, 2020
This was referenced Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants