Remove z-index from placeholder fieldset #23152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
tellthemachines
added
[Feature] Blocks
|
Size Change: -6 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Jun 15, 2020
| @@ -58,7 +58,6 @@ | |||
| flex-direction: row; | |||
| width: 100%; | |||
| flex-wrap: wrap; | |||
| z-index: z-index(".components-placeholder__fieldset"); | |||
There was a problem hiding this comment.
Do you know why this was added in the first place?
There was a problem hiding this comment.
There's a comment on the other file: // Should have higher index than the inset/underlay used for dragging . Something may have changed since it was added, because the fieldsets are all usable without the z-index. I also tested the dragging functionality (for image blocks and the like) and everything seems fine.
This was referenced Jun 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed unnecessary z-index from placeholder fieldset, to fix this issue:
How has this been tested?
Tested in browser with all blocks that have placeholders. Placeholder functionality is unaffected.
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: