Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Media & Text to use functional components #23102

Merged
merged 9 commits into from
Jun 16, 2020
Merged

Refactor Media & Text to use functional components #23102

merged 9 commits into from
Jun 16, 2020

Conversation

oxyc
Copy link
Member

@oxyc oxyc commented Jun 11, 2020 •
edited
Loading

Description

Originally submitted together with light block DOM conversion but now split into it's own PR to only refactor the Media & Text block using functional components. Original PR is here #23062

Note that there might be some prep here for rendering MediaContainer as a <figure> directly.

How has this been tested?

Tested adding video as well as image and toggling all the attributes to see that everything is working.

Screenshots

Types of changes

Refactor

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@oxyc oxyc requested review from ajitbohra, Soean and talldan as code owners June 11, 2020 19:42
@oxyc oxyc mentioned this pull request Jun 11, 2020
Merged
6 tasks
@oxyc oxyc mentioned this pull request Jun 11, 2020
Open
ZebulanStanphill
ZebulanStanphill approved these changes Jun 12, 2020
View reviewed changes
Copy link
Member

@ZebulanStanphill ZebulanStanphill left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and testing the branch hasn't revealed any issues. Looks good to merge (LGTM)!

packages/block-library/src/media-text/edit.js Outdated Show resolved Hide resolved
@ZebulanStanphill ZebulanStanphill added [Block] Media & Text Affects the Media & Text Block [Package] Block library /packages/block-library [Type] Code Quality Issues or PRs that relate to code quality labels Jun 12, 2020
@oxyc oxyc mentioned this pull request Jun 15, 2020
Closed
@ZebulanStanphill ZebulanStanphill merged commit 8258f40 into WordPress:master Jun 16, 2020
@github-actions github-actions bot added this to the Gutenberg 8.4 milestone Jun 16, 2020
This was referenced Jun 24, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellatrix ellatrix ellatrix left review comments

@ZebulanStanphill ZebulanStanphill ZebulanStanphill approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

Assignees
No one assigned
Labels
[Block] Media & Text Affects the Media & Text Block [Package] Block library /packages/block-library [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 8.4
Development

Successfully merging this pull request may close these issues.
3 participants
@oxyc @ellatrix @ZebulanStanphill