-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image editing: move to image block #23053
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -47 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
try/move-image-editor
branch
2 times, most recently
from
June 11, 2020 19:29
c420dc5
to
d8bdbc7
Compare
ellatrix
force-pushed
the
try/move-image-editor
branch
from
June 11, 2020 19:41
d8bdbc7
to
295f2f4
Compare
ZebulanStanphill
added
the
[Type] Code Quality
Issues or PRs that relate to code quality
label
Jun 14, 2020
This was referenced Jun 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the image editing component to the block. In the future, if this component could be useful for other blocks and if it is ready, we can consider creating a separate component in the block editor package, maybe similar to the replace flow. Having it in the block library as a filter for a block doesn't make much sense right now.
How has this been tested?
Everything should be the same as before.
Screenshots
Types of changes
Checklist: