Fix drag and drop for blocks that don't use __experimentalTagName for their inner blocks
#23016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
|
Size Change: -2 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
ellatrix
reviewed
Jun 9, 2020
| @@ -113,11 +113,7 @@ function UncontrolledInnerBlocks( props ) { | |||
| return blockList; | |||
| } | |||
|
|
|||
| return ( | |||
| <div className="block-editor-inner-blocks" ref={ forwardedRef }> | |||
There was a problem hiding this comment.
forwardedRef sounds like a leftover from a class component. Ideally, we should be using the forwardRef HoC to get a ref.
ellatrix
approved these changes
Jun 9, 2020
This was referenced Jun 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently while looking into drag and drop related issues I discovered a couple of reasons that drag and drop commonly doesn't work on Inner Blocks:
__experimentalTagName, it'srefis not set correctly, and theuseBlockDropZonehook that uses this ref fails silently.This PR fixes the second issue by ensuring the ref passed to
InnerBlocksis correctly passed toBlockList:gutenberg/packages/block-editor/src/components/inner-blocks/index.js
Line 94 in 8ac2826
And not overwritten a few lines later by also being passed to the
block-editor-inner-blockselement:gutenberg/packages/block-editor/src/components/inner-blocks/index.js
Line 117 in 8ac2826
How has this been tested?
The easiest block to test with is Media and Text
master.Bug fix (non-breaking change which fixes an issue)
Checklist: