Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ImageSizeControl to functional components. #22899

Merged
merged 2 commits into from
Jun 4, 2020
Merged

Refactor ImageSizeControl to functional components. #22899

merged 2 commits into from
Jun 4, 2020

Conversation

torounit
Copy link
Member

@torounit torounit commented Jun 4, 2020 •
edited
Loading

Description

Related #22890

Refactored ImageSizeControl to functional components.

Testing instructions

Make sure that uploading images using the Image block "upload" button works as expected

How has this been tested?

  1. Create Image block.
  2. Set width, height and reset.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@youknowriad youknowriad added [Type] Code Quality Issues or PRs that relate to code quality Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code labels Jun 4, 2020
@ZebulanStanphill ZebulanStanphill added the [Package] Block editor /packages/block-editor label Jun 4, 2020
@ItsJonQ ItsJonQ self-requested a review June 4, 2020 15:44
ItsJonQ
ItsJonQ approved these changes Jun 4, 2020
View reviewed changes
Copy link

@ItsJonQ ItsJonQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@torounit Thank you for working on this! The conversion looks good to me. I tested it on my side, and the Image block + it's resizing feature is working as expected.

@ZebulanStanphill 's suggestion regarding undefined makes sense. I do understand that it was something that was carried over during the conversion process.

This isn't a blocker for me for merging this PR.

Thanks ❤️

@ItsJonQ
Copy link

ItsJonQ commented Jun 4, 2020

@torounit Awesome! Thank you for that update! We'll wait for Travis to be green and happy. I'll merge it as soon as that's ready

Thank you for contributing 🙏

@ItsJonQ ItsJonQ merged commit 394a21b into WordPress:master Jun 4, 2020
@github-actions github-actions bot added this to the Gutenberg 8.3 milestone Jun 4, 2020
@torounit torounit deleted the refactor/image-size-control branch June 4, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZebulanStanphill ZebulanStanphill ZebulanStanphill left review comments

@ItsJonQ ItsJonQ ItsJonQ approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code [Package] Block editor /packages/block-editor [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 8.3
Development

Successfully merging this pull request may close these issues.
4 participants
@torounit @ItsJonQ @ZebulanStanphill @youknowriad