Support a more flexible useItems API for the autocompleters API #22853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Feature] Rich Text
youknowriad
requested review from
ajitbohra,
chrisvanpatten and
jorgefilipecosta
as code owners
|
Size Change: -165 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
ellatrix
reviewed
Jun 12, 2020
|
I'm fine with this, if it helps. Would be nice to see usage of the hook |
|
E2e tests that use the slash inserter fail on Travis, I think it's a bad sign 😅 |
|
I tested it locally and it works perfectly fine in all the cases I tested:
|
youknowriad
force-pushed
the
update/autocompleter-hook
branch
from
d37c1ce to
73dbcd3
Compare
youknowriad
force-pushed
the
update/autocompleter-hook
branch
from
feb1020 to
5754c4b
Compare
youknowriad
force-pushed
the
update/autocompleter-hook
branch
from
5754c4b to
2cca698
Compare
|
The test changes are actually intermittent failures on master too. they are though harder to trigger on master (I was able to do it something though) |
gziolo
approved these changes
Jun 22, 2020
youknowriad
added
the
[Type] New API
This was referenced Jun 22, 2020
mcsf
reviewed
Sep 7, 2020
Comment on lines
+145
to
+147
| const useItems = autocompleter.useItems | ||
| ? autocompleter.useItems | ||
| : ( filterValue ) => { |
There was a problem hiding this comment.
Are we confident now to document useItems, or is there a reason to wait?
There was a problem hiding this comment.
There are some potential things we may want to add, like a way to show alternative UIs (not just a flat list) but I do feel confident about useItems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the autocompleters API is a bit limitted and relies only on global functions to fetch the options. It also doesn't allow us to reuse logic easily: for instance the Inserter use hooks to fetch the available items to insert but these hooks can't be reused inside the autocompleter itself which make it very hard to support things like: block variations, block patterns... without duplicating a lot of logic.
This PR updates the
Autocompletecomponent to rely on auseItemshook in the autocompleter definition. If the hook has not been provided, a default one relying on the existing autocompeters API is used.That component is a bit complex, so potential regressions are not excluded.
As a follow-up I'll be updating the block autocompleter to support patterns and block variations.
Testing instructions