Framework: Use WordPress dependencies in favor of globals #2275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
Framework
Codecov Report
@@ Coverage Diff @@
## master #2275 +/- ##
=======================================
Coverage 23.78% 23.78%
=======================================
Files 147 147
Lines 4553 4553
Branches 772 772
=======================================
Hits 1083 1083
Misses 2929 2929
Partials 541 541
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1205
Related: #742
This pull request seeks to use WordPress dependencies consistently as imports within the codebase. It is a reattempt at #742, though happily I found that the overall number of occurrences has dropped significantly.
Testing instructions:
Ensure the build completes, tests pass, and editor initializes and appears without regressions. Specifically observe that no errors are logged to the console.