-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wp-env: Set wp tests domain to localhost url #22476
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
epiqueras
requested changes
May 19, 2020
c19eb68
to
1e530d9
Compare
1e530d9
to
efe86c9
Compare
epiqueras
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Writing an e2e test yesterday, I noticed that
npm run test-e2e:watch
was wailing because it was visitingexample.com
instead oflocalhost:8889
. This is caused by #20090, which setWP_TESTS_DOMAIN
toexample.com
.This PR fixes that by setting the test domain to the localhost WordPress url.
How has this been tested?
After cleaning and restarting wordpress locally, the test domain was set to the localhost URL, and the e2e tests started working again.
Types of changes
bug fix
Checklist: