-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query Block: Don't pass down available_context
.
#22364
Merged
epiqueras
merged 1 commit into
master
from
update/query-block-dont-pass-down-available-context
May 14, 2020
Merged
Query Block: Don't pass down available_context
.
#22364
epiqueras
merged 1 commit into
master
from
update/query-block-dont-pass-down-available-context
May 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epiqueras
added
[Type] Bug
An existing feature does not function as intended
[Feature] Full Site Editing
labels
May 14, 2020
epiqueras
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
May 14, 2020 18:21
Size Change: 0 B Total Size: 832 kB ℹ️ View Unchanged
|
aduth
approved these changes
May 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems fine to address the immediate issue, if there's not a need for it 👍
I might still like to explore something like mentioned at #22199 (comment), though it can be done separately.
I don't see how portals relate to this issue. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #22199 (comment).