Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit mode: arrow up/down should not move to other blocks #22204

Closed
wants to merge 8 commits into from
Closed

Edit mode: arrow up/down should not move to other blocks #22204

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
22f5e53
Test code
May 8, 2020
c1283fe
Do not skip to another block on up/down arrow press.
May 8, 2020
7aef537
Code cleanup.
May 8, 2020
57f91ee
Merge pull request #1 from WordPress/master
alexstine May 8, 2020
65a8a7a
Merge branch 'master' of github.com:alexstine/gutenberg into fix/bloc…
May 8, 2020
c48dc94
Merge pull request #2 from WordPress/master
alexstine May 13, 2020
d28718f
Merge branch 'master' of github.com:alexstine/gutenberg into fix/bloc…
May 13, 2020
9a1f0d3
Get rid of horizontal navigation.
May 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 0 additions & 29 deletions packages/block-editor/src/components/writing-flow/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import {
isTextField,
isVerticalEdge,
placeCaretAtHorizontalEdge,
placeCaretAtVerticalEdge,
isEntirelySelected,
} from '@wordpress/dom';
import {
Expand Down Expand Up @@ -538,34 +537,6 @@ export default function WritingFlow( { children } ) {
// Moving from block multi-selection to single block selection
moveSelection( isReverse );
event.preventDefault();
} else if ( isVertical && isVerticalEdge( target, isReverse ) ) {
const closestTabbable = getClosestTabbable(
target,
isReverse,
container.current,
true
);

if ( closestTabbable ) {
placeCaretAtVerticalEdge(
closestTabbable,
isReverse,
verticalRect.current
);
event.preventDefault();
}
} else if (
isHorizontal &&
getSelection().isCollapsed &&
isHorizontalEdge( target, isReverseDir )
) {
const closestTabbable = getClosestTabbable(
target,
isReverseDir,
container.current
);
placeCaretAtHorizontalEdge( closestTabbable, isReverseDir );
event.preventDefault();
}
}

Expand Down