-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block: avoid useLayoutEffect #22108
Merged
Merged
Block: avoid useLayoutEffect #22108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 821 kB ℹ️ View Unchanged
|
ellatrix
added
[Type] Code Quality
Issues or PRs that relate to code quality
[Type] Performance
Related to performance efforts
labels
May 5, 2020
ellatrix
force-pushed
the
try/block-remove-layout-effect
branch
from
May 5, 2020 16:22
8441503
to
8a1839b
Compare
ZebulanStanphill
changed the title
Block: avoid useSetLayoutEffect
Block: avoid useLayoutEffect
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Type] Code Quality
Issues or PRs that relate to code quality
[Type] Performance
Related to performance efforts
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #22099. There's no reason to use
useLayoutEffect
. It seems it was only necessary to make Travis happy, which can be replace withwaitForSelector
.How has this been tested?
Screenshots
Types of changes
Checklist: