Add context-splitting for the string "none" #22095
Conversation
audrasjb
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta,
mkevins,
pinarol,
Soean,
talldan and
youknowriad
as code owners
|
Fixes #22094 |
|
I fixed one of the 3 linting errors, but I can't see what I need to do to fix the two last ones. Could someone explain me the issue please? thanks 🙂 |
|
Ok checks are green now 🍏 🙂 |
|
Seems good but I don't have a good i18n knowledge to judge the context splitting here. ccc @swissspidy @mcsf |
| @@ -343,7 +343,7 @@ class ButtonEdit extends Component { | |||
| icon={ ! isCompatibleWithSettings && LinkRelIcon } | |||
| label={ __( 'Link Rel' ) } | |||
| value={ rel || '' } | |||
| valuePlaceholder={ __( 'None' ) } | |||
| valuePlaceholder={ _x( 'None', 'Rel attribute value' ) } | |||
There was a problem hiding this comment.
| valuePlaceholder={ _x( 'None', 'Rel attribute value' ) } | |
| valuePlaceholder={ _x( 'None', 'Link rel attribute value placeholder' ) } |
|
One suggestion and 1 conflict that needs to be resolved, otherwise LGTM |
| { value: 'none', label: __( 'None' ) }, | ||
| { | ||
| value: 'none', | ||
| label: _x( 'None', 'Preload value' ), |
There was a problem hiding this comment.
Perhaps:
| label: _x( 'None', 'Preload value' ), | |
| label: _x( 'None', '"Preload" value' ), |
would make it more explicit.
I was also going to suggest appending "for Audio block" but I see that Video is meant to reuse this context.
There was a problem hiding this comment.
Speaking of which, that __( 'Preload' ) just a few lines above seems like a quick win to add to this PR. 😉
_x( 'Preload', 'noun; Audio block parameter' )
|
Looks like this is approved and went a bit stale? Can we refresh nd land it? |
|
I merged trunk and resolved conflicts in trunk...fix/contextualize-none-strings |
ramonjd
added
the
Internationalization (i18n)
|
@audrasjb I'm happy to carry this one forward if you don't have time. Agree with other folks that it would be good to land to make life for our translators a little easier 😄 |
|
Thank you for the proposal @ramonjd. Very appreciated cause I'm currently on holidays 😅 |
Nice! Hope you have a great time. Wish I were on holidays too 🤣 I'll spin up a new PR soon. Thanks for your work on this. |
…rom #22095 This is because "None" can be translated differently in languages other than English depending on the context.
|
Updated PR #34341 Closing this one. Thank you! |
* Adding context to 'none' strings, and also implementing suggestions from #22095 This is because "None" can be translated differently in languages other than English depending on the context. * As always, my linter was asleep
Description
The strings "None" and "none" are used in many places.
Unfortunately, this string is impossible to translate correctly in many languages.
The reason is that depending on what noun is described, this word may need to be presented in various forms.
For reference, see the original ticket on Trac.
This changeset replaces
__( 'None' )occurrences with_x( 'None', 'Some context )Fixes #22094
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: