Fix entity selection through save panel #22011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -19 B (0%) Total Size: 825 kB
ℹ️ View Unchanged
|
Addison-Stavlo
commented
May 1, 2020
Addison-Stavlo
added
[Feature] Full Site Editing
[Type] Bug
Addison-Stavlo
changed the title
epiqueras
approved these changes
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR disables the 'Select' button in the entity save panel when an entity is already selected.
As note by @vindl here, the new 'Select' entity button for the save panel will appear to de-select the entity if it is already selected. Subsequent clicks do not re-select. After investigation, it seems the entity does remain 'selected' but the button takes takes focus. I think it makes the most sense to disable the 'Select' button if the entity is already selected:
How has this been tested?
Tested locally on post and site editors.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: