Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types: Restore element, icons, primitives types #21781

Merged
merged 3 commits into from
Apr 28, 2020
Merged

Types: Restore element, icons, primitives types #21781

merged 3 commits into from
Apr 28, 2020

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented Apr 22, 2020 •
edited
Loading

Description

Restore generated and published types for element, icons, and primitives packages.

Related:

How has this been tested?

Tests pass.

Types of changes

New feature:

  • Add (restore) types for element, icons, primitives.

@sirreal sirreal added [Status] In Progress Tracking issues with work in progress [Type] Code Quality Issues or PRs that relate to code quality npm Packages Related to npm packages [Package] Element /packages/element [Package] Primitives /packages/primitives [Package] Icons /packages/icons labels Apr 22, 2020
@sirreal sirreal self-assigned this Apr 22, 2020
@sirreal sirreal mentioned this pull request Apr 22, 2020
Merged
7 tasks
@github-actions
Copy link

github-actions bot commented Apr 22, 2020 •
edited
Loading

Size Change: 0 B

Total Size: 816 kB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.02 kB 0 B
build/annotations/index.js 3.62 kB 0 B
build/api-fetch/index.js 4.08 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.23 kB 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 761 B 0 B
build/block-editor/index.js 106 kB 0 B
build/block-editor/style-rtl.css 10.2 kB 0 B
build/block-editor/style.css 10.2 kB 0 B
build/block-library/editor-rtl.css 7.03 kB 0 B
build/block-library/editor.css 7.03 kB 0 B
build/block-library/index.js 114 kB 0 B
build/block-library/style-rtl.css 7.14 kB 0 B
build/block-library/style.css 7.14 kB 0 B
build/block-library/theme-rtl.css 683 B 0 B
build/block-library/theme.css 685 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 48.1 kB 0 B
build/components/index.js 179 kB 0 B
build/components/style-rtl.css 16.9 kB 0 B
build/components/style.css 16.9 kB 0 B
build/compose/index.js 6.66 kB 0 B
build/core-data/index.js 11.4 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.42 kB 0 B
build/date/index.js 5.47 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.1 kB 0 B
build/edit-navigation/index.js 3.54 kB 0 B
build/edit-navigation/style-rtl.css 485 B 0 B
build/edit-navigation/style.css 485 B 0 B
build/edit-post/index.js 27.6 kB 0 B
build/edit-post/style-rtl.css 12.2 kB 0 B
build/edit-post/style.css 12.2 kB 0 B
build/edit-site/index.js 10.9 kB 0 B
build/edit-site/style-rtl.css 5.11 kB 0 B
build/edit-site/style.css 5.11 kB 0 B
build/edit-widgets/index.js 7.49 kB 0 B
build/edit-widgets/style-rtl.css 4.67 kB 0 B
build/edit-widgets/style.css 4.66 kB 0 B
build/editor/editor-styles-rtl.css 428 B 0 B
build/editor/editor-styles.css 431 B 0 B
build/editor/index.js 43.4 kB 0 B
build/editor/style-rtl.css 3.27 kB 0 B
build/editor/style.css 3.27 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.63 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.51 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.12 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 5.29 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.67 kB 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/rich-text/index.js 14.8 kB 0 B
build/server-side-render/index.js 2.68 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.28 kB 0 B
build/url/index.js 4.02 kB 0 B
build/viewport/index.js 1.84 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

@sirreal sirreal mentioned this pull request Apr 22, 2020
Closed
@sirreal sirreal force-pushed the update/restore-element-types branch from d25fb6e to d27205e Compare April 22, 2020 15:37
@sirreal sirreal force-pushed the update/restore-element-types branch from d27205e to 0b23b89 Compare April 27, 2020 20:18
@sirreal sirreal mentioned this pull request Apr 27, 2020
Merged
6 tasks
@sirreal sirreal removed the [Status] In Progress Tracking issues with work in progress label Apr 27, 2020
@sirreal sirreal marked this pull request as ready for review April 27, 2020 20:31
@sirreal sirreal requested review from aduth, gziolo and dsifford April 27, 2020 20:32
@sirreal
Copy link
Member Author

sirreal commented Apr 27, 2020

With DefinitelyTyped/DefinitelyTyped#44086 landed, we should be set to publish element types again.

gziolo
gziolo approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like before. Let's give it a go.

I'm still not sure how to tackle npm release this week because the Gutenberg plugin RC release is already out. We should consider cherry-picking this PR.

@sirreal
Copy link
Member Author

sirreal commented Apr 28, 2020

I'm still not sure how to tackle npm release this week because the Gutenberg plugin RC release is already out. We should consider cherry-picking this PR.

Whenever it makes sense for you. No need to rush this from my end.

@sirreal sirreal merged commit d20e340 into master Apr 28, 2020
@sirreal sirreal deleted the update/restore-element-types branch April 28, 2020 08:03
@github-actions github-actions bot added this to the Gutenberg 8.1 milestone Apr 28, 2020
@aduth aduth mentioned this pull request May 14, 2020
Merged
@aduth aduth mentioned this pull request Jun 2, 2020
Closed
75 tasks
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@youknowriad youknowriad Awaiting requested review from youknowriad

@aduth aduth Awaiting requested review from aduth

@dsifford dsifford Awaiting requested review from dsifford

Assignees

@sirreal sirreal

Labels
npm Packages Related to npm packages [Package] Element /packages/element [Package] Icons /packages/icons [Package] Primitives /packages/primitives [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 8.1
Development

Successfully merging this pull request may close these issues.
2 participants
@sirreal @gziolo