Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code example in PluginBlockSettingsMenuItem docs #21607

Merged
merged 2 commits into from
Nov 14, 2020

Conversation

adekbadek
Copy link
Contributor

Small tweak

@mkaz
Copy link
Member

mkaz commented Apr 15, 2020

Hi, thank you for this change. It looks good, but one small issue is the PR is opened against the wp/5.4 branch and should be opened against the master branch.

You should be able to edit this PR and switch the branch it is against to master - see this documentation to illustrate changing the base branch.

Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good, thanks! See my above comment for switching the PR branch and we can merge.

@gziolo gziolo changed the base branch from wp/5.4 to master April 15, 2020 18:27
@gziolo gziolo changed the base branch from master to wp/5.4 April 15, 2020 18:27
@gziolo
Copy link
Member

gziolo commented Apr 15, 2020

I tried to switch branches but it isn't straightforward.

@mkaz
Copy link
Member

mkaz commented Apr 15, 2020

Thanks @gziolo for trying, I think @adekbadek will have to do it since its from his fork.

I created this Trac ticket to hopefully prevent future ones: https://meta.trac.wordpress.org/ticket/5151

@adekbadek adekbadek changed the base branch from wp/5.4 to master April 16, 2020 09:19
@adekbadek adekbadek changed the base branch from master to wp/5.4 April 16, 2020 09:19
@adekbadek adekbadek changed the base branch from wp/5.4 to master April 16, 2020 09:24
@adekbadek
Copy link
Contributor Author

@mkaz done 👍

@mkaz
Copy link
Member

mkaz commented Apr 16, 2020

@adekbadek It looks like the change did not trigger a new build. I think you will need to push a new commit to the branch to trigger the build.

@aduth
Copy link
Member

aduth commented Apr 16, 2020

I pushed an empty commit in 88d3e3f.

It appears to have worked to kick off the build: https://travis-ci.com/github/WordPress/gutenberg/builds/160567533

@gziolo gziolo added the [Type] Developer Documentation Documentation for developers label Nov 14, 2020
@gziolo gziolo merged commit f3af80f into WordPress:master Nov 14, 2020
@github-actions github-actions bot added this to the Gutenberg 9.4 milestone Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants