-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix code example in PluginBlockSettingsMenuItem docs #21607
Conversation
Hi, thank you for this change. It looks good, but one small issue is the PR is opened against the You should be able to edit this PR and switch the branch it is against to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good, thanks! See my above comment for switching the PR branch and we can merge.
I tried to switch branches but it isn't straightforward. |
Thanks @gziolo for trying, I think @adekbadek will have to do it since its from his fork. I created this Trac ticket to hopefully prevent future ones: https://meta.trac.wordpress.org/ticket/5151 |
@mkaz done 👍 |
@adekbadek It looks like the change did not trigger a new build. I think you will need to push a new commit to the branch to trigger the build. |
I pushed an empty commit in 88d3e3f. It appears to have worked to kick off the build: https://travis-ci.com/github/WordPress/gutenberg/builds/160567533 |
Small tweak