Components: SelectControl - Add isLoading prop #21435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsJonQ
requested review from
ajitbohra,
chrisvanpatten,
ellatrix,
jorgefilipecosta and
youknowriad
as code owners
|
Size Change: +138 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
|
What is a good way to test this? |
|
heya @MichaelArestad ! Oh dear, my apologies! I should have included testing instructions.
That will toggle the state and the UI |
MichaelArestad
added
the
Needs Accessibility Feedback
|
This looks good and works well. I added the "Needs Accessibility Feedback" label just to have someone take a look at that aspect of it. |
ItsJonQ
force-pushed
the
update/select-control-loading-state
branch
from
b2b4a14 to
03169ee
Compare
|
@ItsJonQ circling back on this PR as it came up in the weekly Editor Bug Scrub. Is there any reason that progress on this PR stopped? |
|
@ciampo and I discussed how to proceed with this PR, and we decided to close this out since the original problem that needed to be fixed (Parent Page selector) is no longer a It would be nice to have somewhat consistent loading states across the component library, but currently there is not enough product need to prioritize it. We'll close this for now and refer back to it when implementing a loading state for the ComboboxControl. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update adds the ability to render a loading state for the
SelectControl(andTreeSelect) components.This can be done by passing a
isLoadingprop, like:GIF shows the
SelectControlswitching from loading to loaded.When
isLoadingis set, theselectHTML element will be disabled.I've added more context re: design in this comment
How has this been tested?
In Storybook and in Jest (unit tests)
Types of changes
isLoadingprop toSelectControloptionelements to account for loadingChecklist:
Resolves: #16026 (comment)