Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] - Layout Template Modal & Button block - Orientation fixes #21290

Merged
merged 3 commits into from
Apr 7, 2020
Merged

[RNMobile] - Layout Template Modal & Button block - Orientation fixes #21290

merged 3 commits into from
Apr 7, 2020

Conversation

geriux
Copy link
Member

@geriux geriux commented Mar 31, 2020 •
edited
Loading

Gutenberg Mobile PR -> wordpress-mobile/gutenberg-mobile#2086

Description

It was reported that the Layout template picker was crashing for the 14.5 version when the Modal was opened and then changing the orientation of the device (only for Android).

The orientation crash was also happening for the Inserter modal but these issues were fixed in this PR to be added in 14.6.

Although the previously mentioned PR fixed the modals crash it also introduced some side effects for the Layout template modal and the Button block.

This PR fixes those issues related to orientation changes on Android.

How has this been tested?

  • Open the WordPress Android app with metro running

  • Button block test

    • Start a new post
    • Add a button block
    • Change the device's orientation
    • Switch back to the previous orientation
    • Expect no link settings to show up

  • Layout preview modal test

    • Start a new page
    • Select a template
    • Expect to see the modal with the preview (do not close it)
    • Change the device's orientation
    • Expect the modal to disappear and no random modals to show up
    • Switch back to the previous orientation
    • Expect the editor to not crash and the template's options to be tappable

Screenshots

Button Block Before Button Block After
Layout Preview Before Layout Preview After

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@geriux geriux added [Status] In Progress Tracking issues with work in progress Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Mar 31, 2020
@github-actions
Copy link

github-actions bot commented Mar 31, 2020 •
edited
Loading

Size Change: 0 B

Total Size: 866 kB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 998 B 0 B
build/annotations/index.js 3.45 kB 0 B
build/api-fetch/index.js 3.39 kB 0 B
build/autop/index.js 2.58 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.02 kB 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 760 B 0 B
build/block-editor/index.js 102 kB 0 B
build/block-editor/style-rtl.css 11 kB 0 B
build/block-editor/style.css 11 kB 0 B
build/block-library/editor-rtl.css 7.21 kB 0 B
build/block-library/editor.css 7.21 kB 0 B
build/block-library/index.js 111 kB 0 B
build/block-library/style-rtl.css 7.5 kB 0 B
build/block-library/style.css 7.51 kB 0 B
build/block-library/theme-rtl.css 669 B 0 B
build/block-library/theme.css 671 B 0 B
build/block-serialization-default-parser/index.js 1.65 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 57.5 kB 0 B
build/components/index.js 191 kB 0 B
build/components/style-rtl.css 15.8 kB 0 B
build/components/style.css 15.7 kB 0 B
build/compose/index.js 6.21 kB 0 B
build/core-data/index.js 10.7 kB 0 B
build/data-controls/index.js 1.04 kB 0 B
build/data/index.js 8.26 kB 0 B
build/date/index.js 5.36 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.05 kB 0 B
build/edit-navigation/index.js 2.4 kB 0 B
build/edit-navigation/style-rtl.css 95 B 0 B
build/edit-navigation/style.css 95 B 0 B
build/edit-post/index.js 92.3 kB 0 B
build/edit-post/style-rtl.css 8.35 kB 0 B
build/edit-post/style.css 8.34 kB 0 B
build/edit-site/index.js 9.04 kB 0 B
build/edit-site/style-rtl.css 3.41 kB 0 B
build/edit-site/style.css 3.41 kB 0 B
build/edit-widgets/index.js 4.43 kB 0 B
build/edit-widgets/style-rtl.css 2.57 kB 0 B
build/edit-widgets/style.css 2.57 kB 0 B
build/editor/editor-styles-rtl.css 423 B 0 B
build/editor/editor-styles.css 426 B 0 B
build/editor/index.js 42.8 kB 0 B
build/editor/style-rtl.css 3.38 kB 0 B
build/editor/style.css 3.38 kB 0 B
build/element/index.js 4.44 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 6.95 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 1.93 kB 0 B
build/html-entities/index.js 621 B 0 B
build/i18n/index.js 3.57 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.3 kB 0 B
build/keycodes/index.js 1.7 kB 0 B
build/list-reusable-blocks/index.js 2.99 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 4.84 kB 0 B
build/notices/index.js 1.57 kB 0 B
build/nux/index.js 3.01 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.54 kB 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 780 B 0 B
build/redux-routine/index.js 2.83 kB 0 B
build/rich-text/index.js 14.5 kB 0 B
build/server-side-render/index.js 2.55 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.28 kB 0 B
build/url/index.js 4.01 kB 0 B
build/viewport/index.js 1.6 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

@geriux geriux changed the title [WIP] [RNMobile] - Layout template picker & Button block - Orientation fixes [RNMobile] - Layout template picker & Button block - Orientation fixes Mar 31, 2020
@geriux geriux removed the [Status] In Progress Tracking issues with work in progress label Mar 31, 2020
@geriux geriux marked this pull request as ready for review March 31, 2020 15:37
@geriux geriux changed the title [RNMobile] - Layout template picker & Button block - Orientation fixes [RNMobile] - Layout Template Modal & Button block - Orientation fixes Mar 31, 2020
@geriux geriux mentioned this pull request Mar 31, 2020
Merged
2 tasks
lukewalczak
lukewalczak approved these changes Apr 1, 2020
View reviewed changes
Copy link
Member

@lukewalczak lukewalczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buttons changes LGTM!

chipsnyder
chipsnyder approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@chipsnyder chipsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @geriux tested the changes on WPAndroid and validated iOS everything works well!

@geriux geriux merged commit 6239b53 into master Apr 7, 2020
@geriux geriux deleted the rnmobile/fix-layout-template-modal-orientation branch April 7, 2020 06:56
@github-actions github-actions bot added this to the Gutenberg 7.9 milestone Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukewalczak lukewalczak lukewalczak approved these changes

@chipsnyder chipsnyder chipsnyder approved these changes

Assignees
No one assigned
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
Gutenberg 7.9
Development

Successfully merging this pull request may close these issues.
3 participants
@geriux @chipsnyder @lukewalczak