Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor spacer block to share edit method with the web. #20746

Merged
merged 3 commits into from
Mar 12, 2020
Merged

Refactor spacer block to share edit method with the web. #20746

merged 3 commits into from
Mar 12, 2020

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Mar 9, 2020 •
edited
Loading

Description

Refactor the spacer block in order to have the same code for the edit method with web and mobile.

This involved refactoring the Block Controls on the web to use a standard component and implement a mobile version of the ResizableBox component.

How has this been tested?

This can be tested on this PR for GB-mobile: wordpress-mobile/gutenberg-mobile#1991

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@SergioEstevao SergioEstevao added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Mar 9, 2020
@SergioEstevao SergioEstevao requested a review from Tug March 9, 2020 21:40
@SergioEstevao SergioEstevao mentioned this pull request Mar 9, 2020
Merged
2 tasks
@github-actions
Copy link

github-actions bot commented Mar 9, 2020 •
edited
Loading

Size Change: +455 B (0%)

Total Size: 864 kB

Filename Size Change
build/block-editor/index.js 105 kB +28 B (0%)
build/block-editor/style-rtl.css 10.6 kB +96 B (0%)
build/block-editor/style.css 10.6 kB +98 B (0%)
build/block-library/editor-rtl.css 7.23 kB -124 B (1%)
build/block-library/editor.css 7.24 kB -123 B (1%)
build/block-library/index.js 115 kB +409 B (0%)
build/block-library/style-rtl.css 7.38 kB -90 B (1%)
build/block-library/style.css 7.39 kB -90 B (1%)
build/blocks/index.js 57.7 kB +5 B (0%)
build/components/index.js 191 kB +146 B (0%)
build/components/style-rtl.css 15.6 kB +48 B (0%)
build/components/style.css 15.6 kB +52 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.01 kB 0 B
build/annotations/index.js 3.43 kB 0 B
build/api-fetch/index.js 3.39 kB 0 B
build/autop/index.js 2.58 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.02 kB 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 760 B 0 B
build/block-library/theme-rtl.css 669 B 0 B
build/block-library/theme.css 671 B 0 B
build/block-serialization-default-parser/index.js 1.65 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/compose/index.js 5.75 kB 0 B
build/core-data/index.js 10.6 kB 0 B
build/data-controls/index.js 1.03 kB 0 B
build/data/index.js 8.22 kB 0 B
build/date/index.js 5.36 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 569 B 0 B
build/dom/index.js 3.06 kB 0 B
build/edit-post/index.js 91.3 kB 0 B
build/edit-post/style-rtl.css 8.64 kB 0 B
build/edit-post/style.css 8.64 kB 0 B
build/edit-site/index.js 4.64 kB 0 B
build/edit-site/style-rtl.css 2.48 kB 0 B
build/edit-site/style.css 2.48 kB 0 B
build/edit-widgets/index.js 4.44 kB 0 B
build/edit-widgets/style-rtl.css 2.58 kB 0 B
build/edit-widgets/style.css 2.58 kB 0 B
build/editor/editor-styles-rtl.css 381 B 0 B
build/editor/editor-styles.css 382 B 0 B
build/editor/index.js 43.8 kB 0 B
build/editor/style-rtl.css 3.98 kB 0 B
build/editor/style.css 3.97 kB 0 B
build/element/index.js 4.45 kB 0 B
build/escape-html/index.js 734 B 0 B
build/format-library/index.js 7.09 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 1.92 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.49 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.3 kB 0 B
build/keycodes/index.js 1.68 kB 0 B
build/list-reusable-blocks/index.js 2.99 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 4.85 kB 0 B
build/notices/index.js 1.57 kB 0 B
build/nux/index.js 3.01 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.54 kB 0 B
build/primitives/index.js 1.49 kB 0 B
build/priority-queue/index.js 780 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/rich-text/index.js 14.3 kB 0 B
build/server-side-render/index.js 2.55 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4 kB 0 B
build/viewport/index.js 1.61 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

Tug
Tug requested changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@Tug Tug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on mobile and it worked well 👍

@SergioEstevao
Copy link
Contributor Author

@Tug updated the code according to your suggestions.

@ZebulanStanphill do you mind to give it another look?

@ZebulanStanphill
Copy link
Member

Tested on desktop; everything seems to be working fine there. 👍

Tug
Tug approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@Tug Tug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SergioEstevao SergioEstevao merged commit 7273202 into master Mar 12, 2020
@SergioEstevao SergioEstevao deleted the rnmobile/refactor_spacer_block branch March 12, 2020 14:19
@github-actions github-actions bot added this to the Gutenberg 7.8 milestone Mar 12, 2020
@jbinda jbinda mentioned this pull request Mar 26, 2020
Merged
6 tasks
@gziolo gziolo mentioned this pull request Apr 27, 2020
Merged
@mchowning mchowning mentioned this pull request Feb 9, 2022
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZebulanStanphill ZebulanStanphill ZebulanStanphill approved these changes

@Tug Tug Tug approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

Assignees
No one assigned
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
Gutenberg 7.8
Development

Successfully merging this pull request may close these issues.
3 participants
@SergioEstevao @ZebulanStanphill @Tug