Convert _experimentalCreateInterpolateElement to a stable api. #20699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerrad
requested review from
ajitbohra,
chrisvanpatten,
ellatrix,
jorgefilipecosta and
youknowriad
as code owners
|
Size Change: -32 B (0%) Total Size: 864 kB
ℹ️ View Unchanged
|
nerrad
commented
Mar 7, 2020
Comment on lines
-5
to
+9
| - Added `__experimentalCreateInterpolateElement` function (see [17376](https://github.com/WordPress/gutenberg/pull/17376)) | ||
| - Added `__experimentalCreateInterpolateElement` function (see [17376](https://github.com/WordPress/gutenberg/pull/17376)) |
There was a problem hiding this comment.
I don't know why all the extra spacing was added to the markdown. It happened on saving the file which leads me to believe there was a markdown linting change or prettier is affecting this maybe?
youknowriad
added
the
Needs Dev Note
youknowriad
approved these changes
Mar 18, 2020
|
This change has been included in the Gutenberg |
Yes, during the WP beta/RC release cycle, these are paused because we may need smaller updates for WordPress, hopefully we can release these this week after WP 5.4 is out. |
|
Ah, thanks for the clarification. It's good to know it didn't get lost in the shuffle :) |
youknowriad
removed
the
Needs Dev Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a part of the experimental API's audit done in #20116 it was agreed that
_experimentalCreateInterpolateElementcould be made a stable api. This pull implements that.How has this been tested?
The function is used in the welcome guide, so I triggered the welcome guide and made sure there were no errors in the console.
Types of changes
This is a function name change. I did a search of existing usage in Gutenberg and replaced with the stable function name:
createInterpolateElement.Checklist: