Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packages: Add and check types #20669

Merged
merged 5 commits into from
Mar 31, 2020
Merged

Packages: Add and check types #20669

merged 5 commits into from
Mar 31, 2020

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented Mar 5, 2020 •
edited
Loading

Description

Type:

  • @wordpress/autop
  • @wordpress/escape-html
  • @wordpress/html-entities

✅ Depends on #18942 (set as merge base)

Part of #18838

How has this been tested?

The following runs without errors:

npm run build:package-types

Declaration files are output to each packages' build-types directory.

Types of changes

New feature: Publish TypeScript type declarations.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@sirreal sirreal added [Status] In Progress Tracking issues with work in progress [Type] Code Quality Issues or PRs that relate to code quality [Package] Autop /packages/autop labels Mar 5, 2020
@sirreal sirreal self-assigned this Mar 5, 2020
@aduth aduth mentioned this pull request Mar 5, 2020
Closed
75 tasks
@github-actions
Copy link

github-actions bot commented Mar 5, 2020 •
edited
Loading

Size Change: +6.96 kB (0%)

Total Size: 866 kB

Filename Size Change
build/api-fetch/index.js 3.39 kB +1 B
build/block-directory/index.js 6.02 kB +1 B
build/block-editor/index.js 102 kB +302 B (0%)
build/block-editor/style-rtl.css 11 kB +14 B (0%)
build/block-editor/style.css 11 kB +17 B (0%)
build/block-library/editor-rtl.css 7.21 kB -11 B (0%)
build/block-library/editor.css 7.21 kB -12 B (0%)
build/block-library/index.js 111 kB +586 B (0%)
build/block-library/style-rtl.css 7.5 kB +11 B (0%)
build/block-library/style.css 7.51 kB +9 B (0%)
build/components/index.js 191 kB +1.61 kB (0%)
build/compose/index.js 6.21 kB +1 B
build/core-data/index.js 10.7 kB +70 B (0%)
build/data-controls/index.js 1.04 kB -1 B
build/data/index.js 8.25 kB -4 B (0%)
build/date/index.js 5.36 kB -2 B (0%)
build/dom/index.js 3.05 kB -1 B
build/edit-post/index.js 92.3 kB +1.11 kB (1%)
build/edit-post/style-rtl.css 8.35 kB -86 B (1%)
build/edit-post/style.css 8.34 kB -85 B (1%)
build/edit-site/index.js 9.04 kB +2.31 kB (25%) 🚨
build/edit-site/style-rtl.css 3.41 kB +508 B (14%) ⚠️
build/edit-site/style.css 3.41 kB +512 B (14%) ⚠️
build/edit-widgets/index.js 4.43 kB +4 B (0%)
build/editor/index.js 42.8 kB +17 B (0%)
build/element/index.js 4.44 kB +1 B
build/format-library/index.js 6.95 kB +1 B
build/hooks/index.js 1.93 kB +1 B
build/html-entities/index.js 621 B -1 B
build/i18n/index.js 3.57 kB +84 B (2%)
build/keyboard-shortcuts/index.js 2.3 kB +2 B (0%)
build/list-reusable-blocks/index.js 2.99 kB +2 B (0%)
build/media-utils/index.js 4.84 kB +3 B (0%)
build/plugins/index.js 2.54 kB -1 B
build/primitives/index.js 1.5 kB -1 B
build/priority-queue/index.js 780 B -1 B
build/redux-routine/index.js 2.83 kB -2 B (0%)
build/rich-text/index.js 14.5 kB +2 B (0%)
build/server-side-render/index.js 2.55 kB -1 B
build/shortcode/index.js 1.69 kB -9 B (0%)
build/token-list/index.js 1.28 kB +1 B
build/url/index.js 4.01 kB +2 B (0%)
build/viewport/index.js 1.6 kB -2 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 998 B 0 B
build/annotations/index.js 3.45 kB 0 B
build/autop/index.js 2.58 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 760 B 0 B
build/block-library/theme-rtl.css 669 B 0 B
build/block-library/theme.css 671 B 0 B
build/block-serialization-default-parser/index.js 1.65 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 57.5 kB 0 B
build/components/style-rtl.css 15.8 kB 0 B
build/components/style.css 15.7 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/edit-navigation/index.js 2.4 kB 0 B
build/edit-navigation/style-rtl.css 95 B 0 B
build/edit-navigation/style.css 95 B 0 B
build/edit-widgets/style-rtl.css 2.57 kB 0 B
build/edit-widgets/style.css 2.57 kB 0 B
build/editor/editor-styles-rtl.css 423 B 0 B
build/editor/editor-styles.css 426 B 0 B
build/editor/style-rtl.css 3.38 kB 0 B
build/editor/style.css 3.38 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keycodes/index.js 1.7 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/notices/index.js 1.57 kB 0 B
build/nux/index.js 3.01 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

@sirreal sirreal changed the title Autop: Add and check types Packages: Add and check types Mar 6, 2020
@sirreal sirreal changed the base branch from master to try/output-typedefs March 6, 2020 10:46
@sirreal sirreal added [Package] HTML entities /packages/html-entities [Package] Escape HTML /packages/escape-html labels Mar 6, 2020
@sirreal sirreal force-pushed the try/output-typedefs branch from d0f8d30 to 106e302 Compare March 11, 2020 18:09
@sirreal sirreal force-pushed the try/output-typedefs branch 3 times, most recently from 449bb18 to 89a0540 Compare March 26, 2020 16:13
@sirreal sirreal force-pushed the add/autop-types branch 2 times, most recently from 2188f57 to 759e5a3 Compare March 27, 2020 17:05
@sirreal sirreal changed the base branch from try/output-typedefs to master March 27, 2020 17:06
@sirreal sirreal marked this pull request as ready for review March 27, 2020 17:16
@sirreal sirreal requested a review from aduth as a code owner March 27, 2020 17:16
@sirreal sirreal requested review from dsifford and gziolo March 27, 2020 17:16
dsifford
dsifford approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@dsifford dsifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work!

@dsifford
Copy link
Contributor

dsifford commented Mar 27, 2020 •
edited by sirreal
Loading

@sirreal what's the plan for the definitelytyped types? Are you planning on deprecating the definitions for these packages after this is merged?

@sirreal
Copy link
Member Author

sirreal commented Mar 27, 2020 •
edited
Loading

@sirreal what's the plan for the definitelytyped types? Are you planning on deprecating the definitions for these packages after this is merged?

Yes, as packages are published with included types I'd expect to start removing the DT types.

@sirreal sirreal mentioned this pull request Mar 29, 2020
Merged
6 tasks
sirreal added a commit that referenced this pull request Mar 29, 2020
@sirreal
Squash and merge #20669 (required)
b3ea174
aduth
aduth approved these changes Mar 31, 2020
View reviewed changes
packages/html-entities/src/index.js Outdated Show resolved Hide resolved
@sirreal sirreal merged commit b4bfbb7 into master Mar 31, 2020
@sirreal sirreal deleted the add/autop-types branch March 31, 2020 18:57
@github-actions github-actions bot added this to the Gutenberg 7.9 milestone Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsifford dsifford dsifford approved these changes

@aduth aduth aduth approved these changes

@gziolo gziolo Awaiting requested review from gziolo

Assignees

@sirreal sirreal

Labels
[Package] Autop /packages/autop [Package] Escape HTML /packages/escape-html [Package] HTML entities /packages/html-entities [Status] In Progress Tracking issues with work in progress [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 7.9
Development

Successfully merging this pull request may close these issues.
3 participants
@sirreal @dsifford @aduth