Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pasting freeform content #2039

Merged
merged 1 commit into from
Jul 26, 2017
Merged

Fix pasting freeform content #2039

merged 1 commit into from
Jul 26, 2017

Conversation

ellatrix
Copy link
Member

Fixes #2008.

@ellatrix ellatrix force-pushed the fix/paste-fallback branch from 7e39c2f to 91a9da5 Compare July 26, 2017 19:21
@ellatrix ellatrix requested a review from aduth July 26, 2017 19:22
@ellatrix
Copy link
Member Author

Hm, not sure what's going wrong again here...

@ellatrix
Copy link
Member Author

Introduced in #1394, which changed the type of the block attribute.

@ellatrix ellatrix self-assigned this Jul 26, 2017
@ellatrix ellatrix added the [Type] Bug An existing feature does not function as intended label Jul 26, 2017
@ellatrix ellatrix added this to the Beta 0.6.0 milestone Jul 26, 2017
aduth
aduth previously requested changes Jul 26, 2017
View reviewed changes
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint errors caused by unused variables nodeListToReact and createElement, but I can confirm this fixes #2008. One other item I notice is that it might be nice to trim the pasted content. Copying from lipsum.com into a new post, for example, causes 2 empty paragraphs to linger. Also one stuck with placeholder event when not selected:

Placeholder

Should be okay to merge with lint issues addressed.

@ellatrix
Copy link
Member Author

Huh. I think I dreamed the tests passed on my side.

@ellatrix
Copy link
Member Author

One other item I notice is that it might be nice to trim the pasted content. Copying from lipsum.com into a new post, for example, causes 2 empty paragraphs to linger. Also one stuck with placeholder event when not selected:

Sounds like something good to do in a separate PR. :)

@ellatrix ellatrix force-pushed the fix/paste-fallback branch from 91a9da5 to 259f1a8 Compare July 26, 2017 20:04
@ellatrix ellatrix dismissed aduth’s stale review July 26, 2017 20:21

Lint issues addressed.

@ellatrix ellatrix merged commit 2b222e4 into master Jul 26, 2017
@ellatrix ellatrix deleted the fix/paste-fallback branch July 26, 2017 20:22
@aduth aduth mentioned this pull request Aug 3, 2017
Closed
ceyhun pushed a commit that referenced this pull request Apr 22, 2020
Merge pull request #2039 from wordpress-mobile/issue/2038-apiFetch
cec2df7 
Add support to Categories as part of the API fetch methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduth aduth aduth left review comments

Assignees

@ellatrix ellatrix

Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Beta 0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ellatrix @aduth