Docs: Fix JavaScript linting command #20371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs say to use run `npm run lint:fix` to automatically fix some issues, that doesn't exist, it should be `npm run lint-js:fix`
brentswisher
added
the
[Type] Developer Documentation
brentswisher
requested review from
ajitbohra and
chrisvanpatten
as code owners
|
Size Change: 0 B Total Size: 864 kB ℹ️ View Unchanged
|
gziolo
approved these changes
Feb 22, 2020
retrofox
pushed a commit
that referenced
this pull request
Feb 23, 2020
The docs say to use run `npm run lint:fix` to automatically fix some issues, that doesn't exist, it should be `npm run lint-js:fix`
retrofox
added a commit
that referenced
this pull request
Feb 25, 2020
* Docs: Fix JavaScript linting command (#20371) The docs say to use run `npm run lint:fix` to automatically fix some issues, that doesn't exist, it should be `npm run lint-js:fix` * block-preview: update doc * block-preview: set onReady as experimental prop * rename reference name * declare `position` constant * improve doc * use onReady name internally * simply running onReady callback * pass the online styles to the callback * avoid var name collisions * block-preview: reduce the computing delay to 0 * block-preview: be able to set previewing delay * rename function/vars. Improve docs. * block-preview: improve Readme doc * block-preview: fix x position. simplify. Co-authored-by: Brent Swisher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The docs say to use run
npm run lint:fixto automatically fix some issues. That doesn't exist, it should benpm run lint-js:fixHow has this been tested?
Review docs
Types of changes
Documentation Update