Add a basic storybook story listing all the @wordpress/icons #20266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Developer Documentation
jasmussen
reviewed
Feb 17, 2020
| <Icon icon={ paragraph } size={ 48 } /> | ||
| <Icon icon={ icons.paragraph } /> | ||
| <Icon icon={ icons.paragraph } size={ 36 } /> | ||
| <Icon icon={ icons.paragraph } size={ 48 } /> |
There was a problem hiding this comment.
Nice dimensions, 1x, 1.5x, 2x. 👌
|
@gziolo Storyshots is failing for a weird reason here. (hooks) |
Yes, this is a known issue with stories and their integrations with other parts of Storybook. The approach we took in other places was to move the part that handles hook to a separate component, e.g.: const LibraryExample = () => { ... };
export const Library = () => <LibraryExample />;:) |
youknowriad
force-pushed
the
add/list-icons-storybook
branch
from
be24294 to
a71ed3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Storybook page listing all the icons with a simple input to filter the icons per name.