Lib: Show error when resolved block template is empty. #20239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WordPress/gutenberg-core Can we get this merged? It's a solid change regardless of how design decides to handle this later on. |
mtias
approved these changes
Feb 17, 2020
epiqueras
deleted the
fix/show-error-when-resolved-block-template-is-empty
branch
| @@ -199,7 +199,7 @@ function gutenberg_find_template( $template_file ) { | |||
| } | |||
| } | |||
| $_wp_current_template_id = $current_template_post->ID; | |||
| $_wp_current_template_content = $current_template_post->post_content; | |||
| $_wp_current_template_content = empty( $current_template_post->post_content ) ? 'Empty template.' : $current_template_post->post_content; | |||
There was a problem hiding this comment.
@epiqueras This string should likely be wrapped in a translation function like __(.
epiqueras
added a commit
that referenced
this pull request
Feb 18, 2020
epiqueras
added a commit
that referenced
this pull request
Feb 18, 2020
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20201
Description
When a resolved block template was empty, the "No matching template found." error message was displayed. This was confusing to users because a template was found; it was just empty.
This PR handles these cases with an "Empty template." error message instead.
How to test this?
front-pagetemplate is rendering.lib/demo-block-templates/front-page.html.Types of Changes
New Feature: There is now a more granular error message to differentiate between when a block template is not found and when a block template is found, but it is empty.
Checklist: