Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the devhub manifest file #20175

Merged
merged 2 commits into from
Feb 12, 2020
Merged

Conversation

chrisvanpatten
Copy link
Contributor

Description

#15639 switched back to using the default manifest.json as the manifest which is used to build the block editor devhub site. The associated meta patch to point to the manifest.json file has also been merged.

Therefore, this PR removes the manifest-devhub.json file. It also fixes some documentation that was referencing the old file.

I've also opened a meta ticket to discuss linking the manifest to Gutenberg's wp/* release branch, but that shouldn't require any changes on the Gutenberg side.

@chrisvanpatten chrisvanpatten self-assigned this Feb 11, 2020
@chrisvanpatten chrisvanpatten added the [Type] Developer Documentation Documentation for developers label Feb 11, 2020
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning it up 👍

@chrisvanpatten chrisvanpatten merged commit 96ccb56 into master Feb 12, 2020
@chrisvanpatten chrisvanpatten deleted the remove/devhub-manifest-file branch February 12, 2020 03:16
@github-actions github-actions bot added this to the Gutenberg 7.6 milestone Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants