Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkControl: Prevent space being reserved for scrollbar when items fit box #19633

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

frontdevde
Copy link
Contributor

Description

This is a minor fix for a visual issue described in #19627 where the LinkControl search results box always reserves space for the scrollbar even when the results fit the box.

Please note that in order to test/observe the issue on master an external mouse must be connected.

Fixes #19627

How has this been tested?

  • Connect an external mouse
  • Add the navigation block
  • Add a new link and find a search result that has three or less results
  • Observe whether space for the scrollbar is reserved

Screenshots

Types of changes

Before:

Screenshot 2020-01-14 at 15 23 17

After:

Screenshot 2020-01-14 at 15 24 46

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@frontdevde frontdevde added [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Block] Navigation Affects the Navigation Block labels Jan 14, 2020
@frontdevde frontdevde requested a review from getdave January 14, 2020 14:46
@frontdevde frontdevde merged commit bff61b8 into master Jan 15, 2020
@frontdevde frontdevde deleted the fix/link-control-scrollbar-issue branch January 15, 2020 08:42
@ellatrix ellatrix added this to the Gutenberg 7.3 milestone Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Feature] List View Menu item in the top toolbar to select blocks from a list of links.
Projects
None yet
3 participants