Build Tooling: Skip package for build if package.json unreadable #19439
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to resolve an issue where
npm run dev
can log errors for missing packages, typically when changing branches to an older branch:The problem is that when switching to older branches where a package may not have yet been implemented, the package may be left lingering in the working directory, presumably because its built contents are considered in
.gitignore
.In these cases, it should be safe to simply ignore the package. The implementation here generalizes this to ignore any directory in
packages
for which thepackage.json
file cannot be read.Testing Instructions:
Verify that an empty directory under
packages
does not cause a build failure onnpm run dev:packages
:mkdir packages/foo
npm run dev:packages