Editor: Fix Block Embed Input size #19438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update fixes the Input vs. Button sizing and alignment as seen in Embed blocks, such as Instagram, Twitter, or YouTube. The problem stemmed from the Placeholder component from `@wordpress/components`. The `display: flex` container caused the `input` to grow responsively (height wise), which was triggered by the mysterious margin below the button. The solution involved neutralizing the margins for both the `input` and `button` elements, allowing for their heights and alignments to match.
ItsJonQ
added
[Type] Bug
ItsJonQ
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta,
talldan and
youknowriad
as code owners
karmatosed
approved these changes
Jan 6, 2020
|
Could this have impacted the table block placeholder
|
|
@youknowriad Oh dear! Let me take a look |
|
@youknowriad Update!~ Yes it did. Although... looking at the Table Block placeholder styles... the relationship of the margins x child elements feel strange. I'm going to follow up with an update to hopefully address both Embed + Table Blocks |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update fixes the Input vs. Button sizing and alignment as seen in Embed
blocks, such as Instagram, Twitter, or YouTube.
The problem stemmed from the Placeholder component from
@wordpress/components.The
display: flexcontainer caused theinputto grow responsively(height wise), which was triggered by the mysterious margin below the button.
The solution involved neutralizing the margins for both the
inputandbuttonelements, allowing for their heights and alignments to match.
How has this been tested?
Tested locally in Gutenberg
Screenshots
Before
After
Margin inconsistencies
Types of changes
The code was introduced in the
@wordpress/componentslayer, for thePlaceholdercomponent. Given how this Component is used within Gutenberg, I feel like this adjustment in margins is a safe fix.Checklist:
Resolves #19420