Add: Block editor keyboard shortcuts on the widgets screen #19432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Feature] Widgets Screen
youknowriad
reviewed
Jan 7, 2020
Co-Authored-By: Riad Benguella <[email protected]>
youknowriad
reviewed
Jan 7, 2020
| @@ -23,6 +24,7 @@ function Layout( { blockEditorSettings } ) { | |||
| return ( | |||
| <SlotFillProvider> | |||
| <DropZoneProvider> | |||
| <BlockEditorKeyboardShortcuts.Register /> | |||
There was a problem hiding this comment.
Do we include <BlockEditorKeyboardShortcuts /> elsewhere on this screen? (we need both the registration and the application of the shortcuts to make them work)
There was a problem hiding this comment.
Yes, we already were applying them here https://github.com/WordPress/gutenberg//blob/cc378e8f09a1d74bc8982e453a532e8c78d52225/packages/edit-widgets/src/components/widget-area/index.js#L127. Before there was no need to register them and things worked now, this PR adds the registering, so the shortcuts continue to work.
youknowriad
approved these changes
Jan 7, 2020
jorgefilipecosta
deleted the
add/block-editor-keyboard-shortcuts-on-the-widgets-screen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the normal block editor shortcuts to the widgets screen.
How has this been tested?
On the widgets screen:
I verified I could duplicate blocks using cmd + shift + d.
I multi-selected some blocks and verified I could delete them using backspace.