Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 link in Handbook for InnerBlocks (and maybe other components missing from handbook?) #15767 #19151

Closed

Conversation

deshabhishek007
Copy link

@deshabhishek007 deshabhishek007 commented Dec 15, 2019

Description

This PR is resolves issue #15767
Created a Folder for InnerBlocks and added an README.MD file

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@talldan
Copy link
Contributor

talldan commented Feb 6, 2020

@deshabhishek007 Thanks for taking this on, and apologies it's taken a little time to code review.

I think the issue with copying the README for InnerBlocks into the handbook, is that the two might fall out of sync. It's not obvious for someone updating the component to also update the new file in this PR.

I noticed there's another link to InnerBlocks in the handbook, and that just links directly to the github readme. That link is here:

I think it'd be better to follow the same approach as that would ensure the reader is always linked to the latest up-to-date doc.

@talldan talldan added [Type] Developer Documentation Documentation for developers First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository labels Feb 6, 2020
@earnjam
Copy link
Contributor

earnjam commented May 13, 2020

The original issue for this PR (#15767) was resolved with #21686, so I'm going to close this one out.

@earnjam earnjam closed this May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants