Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi select: remove unneeded scrolling #18972

Closed
wants to merge 1 commit into from
Closed

Multi select: remove unneeded scrolling #18972

wants to merge 1 commit into from

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Dec 6, 2019 •
edited
Loading

Description

I'm not quite sure why this component is here, but it gets really into the way of selecting blocks. During selection, the page always get scrolled, which is disorienting. With the new selection behaviour, I don't think this scrolling behaviour is needed anymore. The browser scrolls the page as you extend the native selection.

Not sure what to do about the exposed component. I just made it render null.

How has this been tested?

Multi select blocks. The page should not scroll unexpectedly.

Screenshots

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@ellatrix ellatrix added the [Feature] Block Multi Selection The ability to select and manipulate multiple blocks label Dec 6, 2019
@ellatrix ellatrix added this to the Gutenberg 7.1 milestone Dec 6, 2019
@ellatrix ellatrix added [Type] Bug An existing feature does not function as intended [Package] Block editor /packages/block-editor labels Dec 6, 2019
@ellatrix ellatrix requested a review from jasmussen December 6, 2019 12:31
@ellatrix ellatrix changed the title Remove scrolling on multi select Multi select: remove unneeded scrolling Dec 6, 2019
@ellatrix
Copy link
Member Author

ellatrix commented Dec 6, 2019

Looks like this was first added in bea06e7 (#3038). This explain why it is needed: for multi selection by keyboard.

@ellatrix
Copy link
Member Author

ellatrix commented Dec 6, 2019

Creating a new PR to fix the implementation.

@ellatrix ellatrix closed this Dec 6, 2019
@ellatrix ellatrix deleted the fix/multi-select-scroll branch December 6, 2019 12:42
@MaxMood96 MaxMood96 mentioned this pull request Jan 18, 2024
Open
@naiba4 naiba4 mentioned this pull request Jan 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

@jasmussen jasmussen Awaiting requested review from jasmussen

Assignees
No one assigned
Labels
[Feature] Block Multi Selection The ability to select and manipulate multiple blocks [Package] Block editor /packages/block-editor [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 7.1
Development

Successfully merging this pull request may close these issues.
1 participant
@ellatrix