-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template Loader: Use glob
constant instead of numeric value.
#18893
Conversation
Can you explain what's meant to be accomplished with this flag? And what was meant to be accomplished with the previous value? (since |
913fd52
to
f2052cf
Compare
I thought the constants were 0 indexed and intended to use |
Does it make a measurable difference? If I find myself questioning why it exists today, I think it would be a fair assumption that it might catch the attention of future maintainers as well, as to why it needs to exist. At the very least, if we keep it, can we add an inline comment explaining its purpose for the benefit of those who work with this code in the future? |
I don't think the minimal performance difference warrants the potential for confusion so I've removed them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for removal. The performance benefit here will be negligible.
Fixes #18876
Description
This PR changes the calls to
glob
in the template loader to use the constantGLOB_NOSORT
instead of the literal1
which seems to have been causing issues in certain environments.How has this been tested?
It was verified that template loading still works as expected.
Checklist: