Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Include TypeScript type checking in Testing Overview #18879

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

aduth
Copy link
Member

@aduth aduth commented Dec 3, 2019

Previously: #17014

This pull request seeks to include testing details about the TypeScript type checking added in #17014, as an extension of the existing documentation for linting overview. This can also serve as a reference for developers in suggesting appropriate editor integrations for TypeScript error highlighting.

Testing Instructions:

As this only includes documentation changes, there is no expected impact on the application runtime.

@aduth aduth added [Type] Developer Documentation Documentation for developers [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. labels Dec 3, 2019
@aduth aduth requested a review from dsifford December 3, 2019 00:41
Copy link
Contributor

@dsifford dsifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks 👍

@aduth aduth merged commit 1a0a97f into master Dec 3, 2019
@aduth aduth deleted the add/typescript-docs branch December 3, 2019 15:38
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants