Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tiny PR] Multi selection: hide toolbar when multi selecting #18836

Closed
wants to merge 1 commit into from

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Nov 29, 2019

Description

This was raised in #16835, though it has been the behaviour for a long time. It does make more sense to hide the block toolbar during multi block selection so that it doesn't interfere when selecting upwards.

How has this been tested?

Select two block dragging from the bottom to the top one. The toolbar should disappear when moving over the block boundary.

Screenshots

select-up

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@ellatrix ellatrix added [Feature] Block Multi Selection The ability to select and manipulate multiple blocks [Package] Block editor /packages/block-editor labels Nov 29, 2019
@youknowriad
Copy link
Contributor

I think there's a small update we can do that can improve the multi-selection feeling. While we're multi-selecting, if we can show the left border while we're selecting, I think it will clarify things more (that's the thing that indicates multi-selection for me right now :) )

Also, ideally, instead oh hiding the toolbar completely, we can show the right toolbar (the multi-selection one)

@ZebulanStanphill
Copy link
Member

@youknowriad Yeah, it feels unresponsive to have the left border and multi-block toolbar not appear until shortly after you let go of the mouse button.

@ellatrix
Copy link
Member Author

ellatrix commented Dec 4, 2019

Closing this in favour of #18915.

@ellatrix ellatrix closed this Dec 6, 2019
@ellatrix ellatrix deleted the fix/hide-toolbar-on-multi-select branch December 6, 2019 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block Multi Selection The ability to select and manipulate multiple blocks [Package] Block editor /packages/block-editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants