-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E Tests: Remove unnecessary font warning exception #18754
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see it was fixed upstream 👍
@aduth I think we need to revert this. I see the error, probably caused by an embed loading fonts.
|
I can't reproduce it locally though. The font is probably ours. |
I'd be okay with this as a short-term resolution, but if it's anything like the previous issue, the fact that the warning occurs is itself a bug which needs to be addressed. These warnings should not be expected. It's hard to tell what might be causing this, given that it cannot be reproduced. In the previous issue, it was a problem of having a duplicate declaration of the font. I wonder if this is happening in the embeds test, that it might have something to do with fonts declared in the I also wonder if it's something where we need to be ignoring warnings which occur within those frames, if we're not already. Seems like we should be wanting to ignore anything within those (I think this might have been one of the motivations for mocking those embed requests?). One thing I've observed with the embeds mocking is that it doesn't seem to be cleaning up after itself, i.e. mocks aren't removed after the tests are run. I could see how this might have some impact on it being intermittent or difficult to reproduce. |
Previously: #15502
See: https://core.trac.wordpress.org/ticket/47183
This pull request seeks to remove an exception added to the E2E test console log monitoring. In the initial release of WordPress 5.2, a warning could occur due to a duplicate
font-face
declaration in the Dashicons stylesheet. This has since been fixed, and was included in the WordPress 5.2.1 maintenance release.Testing Instructions:
The Travis build should not fail.