Fix hidden post schedule popover on mobile #18658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
youknowriad
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta and
talldan
as code owners
gwwar
reviewed
Nov 21, 2019
| // Used to prevent z-index issues on mobile. | ||
| // See: https://github.com/WordPress/gutenberg/pull/7621#issuecomment-424322735 | ||
| .components-popover.edit-post-post-schedule__dialog.is-bottom.is-left { | ||
| z-index: 100000; |
gwwar
approved these changes
Nov 21, 2019
There was a problem hiding this comment.
Thanks @youknowriad this tests well for me on both Desktop/Mobile size viewports!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #18649
We had a special z-index hack introduced in #7621 (comment)
It looks like this regressed with #18044 but the good news is that removing the hack is the fix for the same issue it was introduced for :). It nice when hacky fixes remove them selves.
Testing instructions