-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Native mobile release v1.16.0 #18210
Commits on Oct 14, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 7478b41 - Browse repository at this point
Copy the full SHA 7478b41View commit details -
Add an apiFetch middleware to automatically handle media upload failu…
…res (#17858) * Add an apiFetch middleware to automatically handle media upload failures * Remove the attachement on failures * Handle errors properly * limit the media upload middleware to the 500 responses * Fix the error handling and unit tests * Api Fetch: Check for 502s and parse uncaught errors in Media Upload middleware.
Configuration menu - View commit details
-
Copy full SHA for cb3b787 - Browse repository at this point
Copy the full SHA cb3b787View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e45acc - Browse repository at this point
Copy the full SHA 1e45accView commit details -
Configuration menu - View commit details
-
Copy full SHA for 090b89e - Browse repository at this point
Copy the full SHA 090b89eView commit details
Commits on Oct 15, 2019
-
Code Style: Change name of accumulated variables when using reduce fu…
…nction (#17893) * Fix issue-7378 - change name of accumulated variables when using reduce function * fix issue-7378 - update variables names * fix issue-7378 - update variables names
Configuration menu - View commit details
-
Copy full SHA for 5051d6a - Browse repository at this point
Copy the full SHA 5051d6aView commit details -
Fix:Image Block: Hide 'noreferrer' and 'noopener' in Link Rel (#17398)
* Update the regex used when removing NEW_TAB_REL and add trimming (+2 squashed commits) Squashed commits: [cf71759c3] Accessibility:Image Block:Link Editor: Move Link Rel field below Open new tab toggle [310a23c33] Fix:Image Block:Link Editor: Hide 'noreferrer' and 'noopener' in Link Rel field * post rebases fixes Co-authored-by: Jorge Costa <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 77c676c - Browse repository at this point
Copy the full SHA 77c676cView commit details -
Configuration menu - View commit details
-
Copy full SHA for be83661 - Browse repository at this point
Copy the full SHA be83661View commit details -
- @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected]
Configuration menu - View commit details
-
Copy full SHA for 693c0b8 - Browse repository at this point
Copy the full SHA 693c0b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7cd263 - Browse repository at this point
Copy the full SHA d7cd263View commit details
Commits on Oct 16, 2019
-
Prevent prependHttp from failing if url is not defined (#17928)
* Check that url is defined before passing into prependHttp * Shift check from component to url lib
Configuration menu - View commit details
-
Copy full SHA for 9515a53 - Browse repository at this point
Copy the full SHA 9515a53View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ea41bf - Browse repository at this point
Copy the full SHA 2ea41bfView commit details -
Storybook: Add stories for Checkbox control component (#17891)
* Add checkbox control stories for Storybook * Update README example to match story, useState * Apply suggestions from code review 👍 Co-Authored-By: Enrique Piqueras <[email protected]> * Update story to match README * Add variants for heading, label, help * Update packages/components/src/checkbox-control/README.md Co-Authored-By: Grzegorz (Greg) Ziółkowski <[email protected]> * Add Knobs addon to Storybook * Move storybook addon to dev-dependencies * Solve lint dependency by excluding stories, dont need in package.json * Apply suggestions from code review Co-Authored-By: Enrique Piqueras <[email protected]> * Update with story level decorators * Switch back to global withKnobs, per story not working * Change the name of the example in ChecboxControl story * Try with the uppercase name of the component exported from stories
Configuration menu - View commit details
-
Copy full SHA for 0ee2b78 - Browse repository at this point
Copy the full SHA 0ee2b78View commit details -
RNMobile Add size options to mobile image block (#17245)
* [RNMobile] Native mobile release v1.11.0 (#17181) * [RNMobile] Fix crash when adding separator * Build: remove global install of latest npm since we want to use the paired node/npm version (#17134) * Build: remove global install of latest npm since we want to use the paired node/npm version * Also update travis to remove --latest-npm flag * [RNMobile] Try dark mode (iOS) (#17067) * Adding dark mode component implemented on list and list block * Adding DarkMode handling to RichText, ToolBar and SafeArea * Mobile: Using DarkMode as HOC * iOS DarkMode: Modified colors on block list and block container * iOS DarkMode: Improved Header Toolbar colors * iOS DarkMode: Removing background from buttons * iOS DarkMode warning and unsupported * iOS DarkMode: MediaPlaceholder * iOS DarkMode: BottomSheets * iOS DarkMode: Inserter * iOS DarkMode: DefaultBlockAppender * iOS DarkMode: PostTite * Update hardcoded colors with variables * iOS DarkMode: Fix bottom-sheet cell value color * iOS DarkMode: More - PageBreak - Add Block Here * iOS DarkMode: Better text color * iOS Darkmode: Code block * iOS DarkMode: HTML View * iOS DarkMode: Improve colors on SafeArea * Fix toolbar not avoiding keyboard regression * Fix native unit tests * Fix gutenberg-mobile unit tests * Adding RNDarkMode mocks * RNMobile: Fix crash when viewing HTML on iOS * [RNMobile] Remove toolbar from html view * [RNMobile] Fix MaxListenersExceededWarning caused by dark-mode event emitter (#17186) * Fix MaxListenersExceededWarning caused by dark-mode event emitter * Checking for setMaxListeners trying to avoid CI error * Adding remove listener to DarkMode HOC * DarkMode: Binding this.onModeChanged to `this` * DarkMode: Adding conditional needed to pass UI Tests on CI * Fix focus title on new posts regression (#17180) * BottomSheet: Setting DashIcon color directly when theme is default (light) (#17193) * Activate Travis CI on rnmobile/master branch (#17229) * Added ability to update image size options (sizeSlug) through a new InspectorControl Cell that leads to a Picker. * Added a style for Size Inspector Controls cell to align it will other cells that have icons. * Add native support for the MediaText block (#16305) * First working version of the MediaText component for native mobile * Fix adding a block to an innerblock list * Disable mediaText on production * MediaText native: improve editor visuals * Move BlockToolbar from BlockList to Layout * Remove BlockEditorProvider from BlockList and add native version of EditorProvider to Editor. Plus support InsertionPoint and BlockListAppender * Update BlockMover for native to hide if locked or if it's the only block * Make the vertical align button work, add more styling options for toolbar buttons * Make sure registerCoreBlocks does not break in production * Copy docblock comment from the web version for registerCoreBlocks * Fix focusing on the media placeholder * Only support adding image for now * Update usage of MediaPlaceholder in MediaContainer * Enable autoScroll for just the out most block list * Fix JS Unit tests * Roll back to IconButton refactor and fix tests * Fix BlockVerticalAlignmentToolbar buttons style on mobile * Fix thing for web and ensure ariaPressed is always passed down * Use AriaPressed directly to style SVG on mobile * Update snapshots * Swtiched to react-native Modal onDismiss property for signaling Picker is ready to show * Added a prop for catching modal dismissal on Android. (onDismiss is iOS only and onModalHide works on Android but breaks on iOS) * Added icon for Inspector Controls size option. Removed style we no longer need. * Added title to size option iOS ActionSheet and left alignstyle to size options BottomSheet * MediaUpload and MediaPlaceholder unify props (#17145) * Unify media placeholder and upload props within media-text (#17268) * [RNMobile] Fix dismiss keyboard button for the post title (#17260) * Set unused functions to undefined instead of false in BottomSheet Modal props * Recover border colors (#17269) * [RNMobile] Insure tapping at end of post inserts at end Previously, tapping at the end of the post would insert a block immediately after the currently selected block. In addition, this commit is cleaning out a few unusued props in the block-list file. * Support group block on mobile (#17251) * First working version of the MediaText component for native mobile * Fix adding a block to an innerblock list * Disable mediaText on production * MediaText native: improve editor visuals * Move BlockToolbar from BlockList to Layout * Remove BlockEditorProvider from BlockList and add native version of EditorProvider to Editor. Plus support InsertionPoint and BlockListAppender * Update BlockMover for native to hide if locked or if it's the only block * Make the vertical align button work, add more styling options for toolbar buttons * Make sure registerCoreBlocks does not break in production * Copy docblock comment from the web version for registerCoreBlocks * Fix focusing on the media placeholder * Only support adding image for now * Update usage of MediaPlaceholder in MediaContainer * Enable autoScroll for just the out most block list * Fix JS Unit tests * Roll back to IconButton refactor and fix tests * Fix BlockVerticalAlignmentToolbar buttons style on mobile * Fix thing for web and ensure ariaPressed is always passed down * Use AriaPressed directly to style SVG on mobile * Update snapshots * Support group block on mobile * Extend shouldShowInsertionPoint condition to be false when group is selected * Code refactor * Update package-lock * Removing old style reference. * Moved Picker for image size options into new ImageSizePicker component. Cleaned up sizeOptionLabels. * Updated total left margin on Android Image size options to be 24 px instead of 28 px * Image Size options hidden behind __DEV__ flag * Remove redundant bg color within button appender (#17325) * [RNMobile] DarkMode improvements (#17309) * Remove the need to import `useStyle` and pass the theme prop on every instance that `withStyle` is used * Implement dark-mode refactor on all components * Fix broken native tests * Fix default block appender background color on DarkMode * DarkMode: Make `useStyle` a class function * Cleaned up default true properties and replaced code with lodash map. * Updated to use BottomSheetPickerCell. Eliminated code, but size options now open over top inspector controls menu. * Added leftalign to PickerCell. * [RNMobile] Add autosave to mobile apps (#17329) * [RNMobile] Fix crash when adding separator * Build: remove global install of latest npm since we want to use the paired node/npm version (#17134) * Build: remove global install of latest npm since we want to use the paired node/npm version * Also update travis to remove --latest-npm flag * [RNMobile] Try dark mode (iOS) (#17067) * Adding dark mode component implemented on list and list block * Adding DarkMode handling to RichText, ToolBar and SafeArea * Mobile: Using DarkMode as HOC * iOS DarkMode: Modified colors on block list and block container * iOS DarkMode: Improved Header Toolbar colors * iOS DarkMode: Removing background from buttons * iOS DarkMode warning and unsupported * iOS DarkMode: MediaPlaceholder * iOS DarkMode: BottomSheets * iOS DarkMode: Inserter * iOS DarkMode: DefaultBlockAppender * iOS DarkMode: PostTite * Update hardcoded colors with variables * iOS DarkMode: Fix bottom-sheet cell value color * iOS DarkMode: More - PageBreak - Add Block Here * iOS DarkMode: Better text color * iOS Darkmode: Code block * iOS DarkMode: HTML View * iOS DarkMode: Improve colors on SafeArea * Fix toolbar not avoiding keyboard regression * Fix native unit tests * Fix gutenberg-mobile unit tests * Adding RNDarkMode mocks * RNMobile: Fix crash when viewing HTML on iOS * [RNMobile] Remove toolbar from html view * [RNMobile] Fix MaxListenersExceededWarning caused by dark-mode event emitter (#17186) * Fix MaxListenersExceededWarning caused by dark-mode event emitter * Checking for setMaxListeners trying to avoid CI error * Adding remove listener to DarkMode HOC * DarkMode: Binding this.onModeChanged to `this` * DarkMode: Adding conditional needed to pass UI Tests on CI * Fix focus title on new posts regression (#17180) * BottomSheet: Setting DashIcon color directly when theme is default (light) (#17193) * Add a preliminary version of the AutosaveMonitor for mobile that calls the "bridge" and asks the native side to save the content * Add autosave mock function for tests * Fix merge conflicts * Fix lint * Re-add autosave on mobile that was removed erroneously during import-merge from rnmobile/master * Remove native variant of AutosaveMonitor and introduces changes at editor store level * Default to false for `isEditedPostAutosaveable` on mobile. There was a typo in the returing value on the previous commit. * Make sure to consider edits to the Title when checking if auto-save is needed * Fix lint * Add isAppender functionality on mobile (#17195) * Add isAppender functionality on mobile * refactor isAppender conditions * Replace dropZoneUIOnly in favour of showMediaSelectionUI * deprecate dropZoneUIOnly and add disableMediaSelection prop * Update test * Refactor tests and change prop name * Remove redundant empty lines * Refactor conditions inside MediaPlaceholder * Update block-editor CHANGELOG * Update packages/block-editor/CHANGELOG.md Co-Authored-By: Grzegorz (Greg) Ziółkowski <[email protected]> * Autosave monitor - Make the mobile editor ping the native at each keystroke, since the deboucing logic is already well defined in the apps. (#17548) * [RNMobile] Refactor Dark Mode HOC (#17552) * [RNMobile] Refactor the Dark Mode HOC to fix naming antipatterns * Fix lint errors * Add .native.js suffix to usePreferredColorScheme * Update usage of theme props renamed to preferredColorScheme * Update usage of theme props renamed to preferredColorScheme * Add missing heading levels to the UI (H4, H5, H6) (#17533) * Fix lint issue (#17598) * Fix list filter on paste for RN mobile. (#17550) * Fix method for RN mobile. * Use array.From instead of slice. * Remove comment and use Array.from directly * Convert from NodeList spreadable to Array.from * Fix lint errors. * Fix documentation examples to use Array.from * Add empty line. * [RNMobile] Move MediaUploadPorgress to its own component folder (#17392) * Move MediaUploadPorgress to its own component folder (native) * MediaUploadProgress - Fix import to code standards * MediaUploadProgress readme * Mobile - MediaUploadProgress README update * Rnmobile/fix link editing on start (#17631) * Don't try to clear links if text is clean. * Commented LinkUI removal test when no URL. * Don't try to remove link if we are at start of link and no actual selection is * Re-implementing #17802, affected by merge. Fixed extra space and unused code. * Fixing lint error, trailing space.
Configuration menu - View commit details
-
Copy full SHA for a24a56d - Browse repository at this point
Copy the full SHA a24a56dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 79f910f - Browse repository at this point
Copy the full SHA 79f910fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 979ac4a - Browse repository at this point
Copy the full SHA 979ac4aView commit details -
Small changes to Git Workflow docs (#17662)
* 💁 add 'upstream' remote * 🐛 origin / remote
Configuration menu - View commit details
-
Copy full SHA for 2da693e - Browse repository at this point
Copy the full SHA 2da693eView commit details -
Codeowners: Remove gziolo from some folders (#17971)
I get too many notifications.
Configuration menu - View commit details
-
Copy full SHA for f38e178 - Browse repository at this point
Copy the full SHA f38e178View commit details -
Fix: Invalid import statement for deprecated in the modal component (#…
…17969) * Fix: Invalid import statement for deprecated in the modal component * Font Size Picker: Update E2E test to work with new Core changes.
Configuration menu - View commit details
-
Copy full SHA for f5f824e - Browse repository at this point
Copy the full SHA f5f824eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d0079a9 - Browse repository at this point
Copy the full SHA d0079a9View commit details -
Try setting a block display name for the Block Navigator. (#17519)
* Really simple first attempt at showing a display name in the navigator * Strip any RichText formatting * Add display name for navigation menu item block * Refactor to use displayNameAttribute property * Change name of displayName options
Configuration menu - View commit details
-
Copy full SHA for 2c11c83 - Browse repository at this point
Copy the full SHA 2c11c83View commit details
Commits on Oct 17, 2019
-
Configuration menu - View commit details
-
Copy full SHA for d79a840 - Browse repository at this point
Copy the full SHA d79a840View commit details -
Configuration menu - View commit details
-
Copy full SHA for a284f26 - Browse repository at this point
Copy the full SHA a284f26View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5991eeb - Browse repository at this point
Copy the full SHA 5991eebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 013ed32 - Browse repository at this point
Copy the full SHA 013ed32View commit details
Commits on Oct 18, 2019
-
Configuration menu - View commit details
-
Copy full SHA for ed24c2f - Browse repository at this point
Copy the full SHA ed24c2fView commit details -
Optimize exports of the wp/compose package (#17945)
Adds `sideEffects:false` to `package.json` so that unused exports can be optimized away by the bundler. Moves the `compose` definition (i.e., reexport from Lodash) to its own module, so that we don't pull in Lodash just by importing something from `@wordpress/compose`. After this patch, one needs to import `compose` explicitly to trigger the Lodash import.
Configuration menu - View commit details
-
Copy full SHA for 55dce15 - Browse repository at this point
Copy the full SHA 55dce15View commit details -
[RNMobile] Introduce grouping in the block settings inspector (#17703)
* Intrdouce groupin in the block settings inspector * Adjust PanelBody to design * Adjust padding when section doesnt have title * Rewirte arrow function to function * Fix lint issue * Create a PanelActions component for handling action buttons in the block settings inspector * Remove useless separator type and fix typo * Refactor after CR * Correct label styles * Fix overriding mechanism on label style
Configuration menu - View commit details
-
Copy full SHA for 69f6a69 - Browse repository at this point
Copy the full SHA 69f6a69View commit details -
Configuration menu - View commit details
-
Copy full SHA for c73d5be - Browse repository at this point
Copy the full SHA c73d5beView commit details -
Storybook: Add knobs to ColorIndicator (#18015)
* Add knobs to ColorIndicator * Lint: new line
Configuration menu - View commit details
-
Copy full SHA for 4e5e7fa - Browse repository at this point
Copy the full SHA 4e5e7faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2052317 - Browse repository at this point
Copy the full SHA 2052317View commit details
Commits on Oct 19, 2019
-
Fix Publish Button!!! (#18016)
Fixes #18004 and thank science, that was driving me insane ever since you pointed it out. This PR does a couple of things: 1. It adds `isLarge` to the Publish button. It was there for Preview, but not Publish. 2. It simplifies a little CSS as a result of that. 3. It also tweaks the button height as defined for the two preview publish buttons.
Configuration menu - View commit details
-
Copy full SHA for a26a263 - Browse repository at this point
Copy the full SHA a26a263View commit details -
Update MediaPlaceholder README.md (#17980)
* Update MediaPlaceholder README.md This change updates the readme to properly document the `value` property. See issue here: #17967 * Update MediaUpload README.md
Configuration menu - View commit details
-
Copy full SHA for ba4793b - Browse repository at this point
Copy the full SHA ba4793bView commit details
Commits on Oct 21, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 5d58806 - Browse repository at this point
Copy the full SHA 5d58806View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26795ca - Browse repository at this point
Copy the full SHA 26795caView commit details -
Configuration menu - View commit details
-
Copy full SHA for dc95b6f - Browse repository at this point
Copy the full SHA dc95b6fView commit details -
- @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected]
Configuration menu - View commit details
-
Copy full SHA for 4df25af - Browse repository at this point
Copy the full SHA 4df25afView commit details
Commits on Oct 22, 2019
-
Chore: Fix issues related to Node 12 becoming LTS (#18054)
* Chore: Fix issues related to Node 12 becoming LTS * Include the root package.json file in the linting This commit also moves the npm-package-json-lint config to the standalone file. * Add changelog entries to @wordpress/scripts package
Configuration menu - View commit details
-
Copy full SHA for a2856b1 - Browse repository at this point
Copy the full SHA a2856b1View commit details -
Fix issue when providing multiple shortcode aliases for a new block (#…
…17925) * Fix issue where providing multiple shortcode aliases to transform into a block only matches the first shortcode * Add test to ensure blocks can transform using multiple shortcode aliases * Simplify the approach used to find the individual shortcode being transformed Props jg314
Configuration menu - View commit details
-
Copy full SHA for 87e4431 - Browse repository at this point
Copy the full SHA 87e4431View commit details -
Chore: Update the lock file to use newer version of fsevents (#18057)
This fixes the issues when `npm install` on macOS throws several errors.
Configuration menu - View commit details
-
Copy full SHA for 6da4593 - Browse repository at this point
Copy the full SHA 6da4593View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d93d0c - Browse repository at this point
Copy the full SHA 0d93d0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for a5c9b11 - Browse repository at this point
Copy the full SHA a5c9b11View commit details -
navigation-menu: Implement colors selector button. (#17832)
Summary block-editor: expose ColorPaletteControl component navigation-menu: improve colors-selector component navigation-menu: compose withColors navigation-menu: render colors selector in bar navigation-menu: propagate withColor props navigation-menu: apply theme styles to selection navigation-item: populate styles to nav item navigation-menu: apply inline styles and CSS classes
1Configuration menu - View commit details
-
Copy full SHA for a25fe28 - Browse repository at this point
Copy the full SHA a25fe28View commit details
Commits on Oct 23, 2019
-
Update design-systems:dev script to build packages (#18073)
The build-style/style.css needs to be rebuilt prior to running Storybook in watch mode. This change adds `npm run build:packages` at the start of the design-systems:dev script to CSS is built prior. Issue found in #17997
Configuration menu - View commit details
-
Copy full SHA for de715f6 - Browse repository at this point
Copy the full SHA de715f6View commit details -
Add
@wordpress/base-styles
package (#17883)- Move `assets/stylesheets/*` to the new package - Move admin color schemes to the new package
Configuration menu - View commit details
-
Copy full SHA for 9783474 - Browse repository at this point
Copy the full SHA 9783474View commit details -
Add Site Title block and required functionality. (#17207)
* Core Data: Add a Site entity and a hook for entity saving logic. * Experiments: Add a Full Site Editing experiment. * Block Library: Add Site Title block. * Fixtures: Add Site Title block fixture. * Fixtures: Add missing transform fixtures. * Block Library: Remove deprecated prop usage in Site Title. * Site Title: Support nesting inside of a Site block. * Site Title: Disallow formatting in the rich text field. * Core Data: Make useEntitySaving experimental.
Configuration menu - View commit details
-
Copy full SHA for 04e142e - Browse repository at this point
Copy the full SHA 04e142eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f77ed22 - Browse repository at this point
Copy the full SHA f77ed22View commit details -
Implement core template loader overrides to rely on wp_template posts (…
…#17626) * Introduce wp_template post type. * Improve (temporary) admin UI for wp_template post type by exposing slug. * Implement template loader overrides to rely on 'wp_template' posts. * Render viewport meta tag. * Prevent deletion of fallback 'wp_template' post 'index'. * Scope PR to just basic wp_template post type registration. * Implement core template loader overrides to rely on wp_template posts instead. * Render title tag regardless of theme support Co-Authored-By: Weston Ruter <[email protected]> * Make getting correct wp_template post more error-proof Co-Authored-By: Weston Ruter <[email protected]> * Template Loader: Add more content filters. * Templates: Fix experiment flag logic.
Configuration menu - View commit details
-
Copy full SHA for 53eca43 - Browse repository at this point
Copy the full SHA 53eca43View commit details -
Add logic for basic (temporary) wp_template editing UI (#17625)
* Templates: Add logic for basic temporary editing UI. * Templates: Fix menu filter. * Post Slug: Follow class name convention.
Configuration menu - View commit details
-
Copy full SHA for 6cf43ac - Browse repository at this point
Copy the full SHA 6cf43acView commit details
Commits on Oct 24, 2019
-
Configuration menu - View commit details
-
Copy full SHA for d4528d8 - Browse repository at this point
Copy the full SHA d4528d8View commit details -
Code style: Fix ESLint warnings reported for JSDoc definitions (#18025)
* Code style: Fix ESLint warnings reported for JSDoc definitions * Add WordPress type definitions to the list of names recognized by JSDoc linter
Configuration menu - View commit details
-
Copy full SHA for 7515397 - Browse repository at this point
Copy the full SHA 7515397View commit details -
Local autosave: Clear after successful save (#18051)
* Local autosave: Clear after successful save Presumably, somewhere in the fixing of conflicts between remote and local autosaves (purge local upon successful remote autosave), LocalAutosaveMonitor stopped purging the local autosave upon successful *saves*. * Tests: Autosave: Correctly wait for editor chrome before saving
Configuration menu - View commit details
-
Copy full SHA for 0b76cc9 - Browse repository at this point
Copy the full SHA 0b76cc9View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2b9682 - Browse repository at this point
Copy the full SHA f2b9682View commit details -
Fix regression with Gallery margin. (#18019)
I failed to verify the Gallery block when I approved #17958 (comment) and therefore caused a regression. This PR adds explicity left margins and paddings to the gallery ul to ensure there isn't any added padding and margin.
Configuration menu - View commit details
-
Copy full SHA for 29fc723 - Browse repository at this point
Copy the full SHA 29fc723View commit details -
Add platform component (#18058)
* Add platform component * Improve platform implementation in RN. * Add more documentation and tests. * Update readme file. * Update tests. * Fix filenames for native versions. * Add license attribution * Remove unnecessary lines. * Improve documentation * Remove trailing space * Update packages/element/src/platform.js Co-Authored-By: Grzegorz (Greg) Ziółkowski <[email protected]> * Update readme. * Fix lint error.
Configuration menu - View commit details
-
Copy full SHA for dd8885b - Browse repository at this point
Copy the full SHA dd8885bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 63a0e56 - Browse repository at this point
Copy the full SHA 63a0e56View commit details -
Fix: Custom button background color not reflected on reload (#18037)
Fixes: #18012 We had a bug where the editor may not reflect the custom button background color after a reload. That happened because the rule background: customGradient, may overwrite the background-color rule even if the custom gradient has not set. This PR performs a logic update to solve the issue.
Configuration menu - View commit details
-
Copy full SHA for b99748f - Browse repository at this point
Copy the full SHA b99748fView commit details -
List Block: Do not merge list with previous block if deleting first l…
…ist item and list is not empty (#18032) * Do not merge list with previous block if deleting first list item and list is not empty * Add e2e test and clean up * Correct mistake * Adjust comment
Configuration menu - View commit details
-
Copy full SHA for ffc4795 - Browse repository at this point
Copy the full SHA ffc4795View commit details -
Configuration menu - View commit details
-
Copy full SHA for 59f7102 - Browse repository at this point
Copy the full SHA 59f7102View commit details -
Components: Add VisuallyHidden component (#18022)
* Add ScreenReaderText component * Add new component readme to manifest * Remove CSS style loading within stories * Switch component name to VisuallyHidden - Rename directory and includes - Update README usage - Update Storybook usage * Switch classname to components-visually-hidden * Lint: newline * Add focus style * Switch to 'as' for specifying tag * Move renderAsRenderProps to utils.js * Move utils to inside component folder Waiting to refine the utils usage a little better before making it look available for other components to use. * Apply suggestions from code review Co-Authored-By: Grzegorz (Greg) Ziółkowski <[email protected]> * Lint: Move newline * Fix variable name * Use variable for stylesheet
Configuration menu - View commit details
-
Copy full SHA for abbdb2b - Browse repository at this point
Copy the full SHA abbdb2bView commit details -
Storybook: Apply a set of enhancements to the existing stories (#18030)
* Storybook: Apply a set of enhancements to the existing stories * Add basic knobs integration to all Button stories
Configuration menu - View commit details
-
Copy full SHA for bef4943 - Browse repository at this point
Copy the full SHA bef4943View commit details
Commits on Oct 25, 2019
-
Env: Add support for running in themes. (#17732)
* Env: Add support for running in themes. * Env: Optimize context detection filter. * Env: Update test directory structure to match convention.
Configuration menu - View commit details
-
Copy full SHA for 2cedba7 - Browse repository at this point
Copy the full SHA 2cedba7View commit details -
Storybook: Add Color Palette Component (#17997)
* Add Color Palette to Storybook * Apply suggestions from code review Co-Authored-By: Enrique Piqueras <[email protected]> * Refactor state out of story components, to own * Update packages/components/src/color-palette/stories/index.js
Configuration menu - View commit details
-
Copy full SHA for 3cf81c7 - Browse repository at this point
Copy the full SHA 3cf81c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 576009f - Browse repository at this point
Copy the full SHA 576009fView commit details -
[rnmobile] Breadcrumbs (#17471)
* Add breadcrumbs to floating toolbar * Add dark mode support
Configuration menu - View commit details
-
Copy full SHA for 56e730b - Browse repository at this point
Copy the full SHA 56e730bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f8b62bd - Browse repository at this point
Copy the full SHA f8b62bdView commit details -
RNMobile: Add image alignment controls (#17962)
RNMobile: Add image alignment controls Only handles left, center, right. Does not permit setting or displaying either full or wide alignments.
Configuration menu - View commit details
-
Copy full SHA for 0f216d8 - Browse repository at this point
Copy the full SHA 0f216d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce2e71c - Browse repository at this point
Copy the full SHA ce2e71cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ac763a - Browse repository at this point
Copy the full SHA 5ac763aView commit details -
Block Editor: Implement new colors hook. (#16781)
* Block Editor: Implement new colors hook. * Block Library: Swap usage of the colors HOC with the colors hook in the heading edit component. * Use Colors: Add 'has-x-color' class names. * Use Colors: Avoid memory leaks by making caches limited in size, and tied to hook instances. * Use Colors: Support children and optional contrast checking in the color panel. * Use Colors: Expose colors panel without inspector slot/fill wrapper. * Use Colors: Mark hook as experimental. * Use Colors: Support custom colors. * Block Edit: Remove extra context values and use selectors/actions instead. * Heading: Remove unnecessary color class and set text color on save. * Use Colors: Add custom/preset color logic. * Use Colors: Fix panel bugs. * Heading Block: Detect actual background color for contrast checking. * Block Edit: Add new export to native file. * Use Colors: Change CSS "attribute" to "property".
2Configuration menu - View commit details
-
Copy full SHA for 434bb66 - Browse repository at this point
Copy the full SHA 434bb66View commit details
Commits on Oct 26, 2019
-
Configuration menu - View commit details
-
Copy full SHA for cb96083 - Browse repository at this point
Copy the full SHA cb96083View commit details
Commits on Oct 27, 2019
-
Nav menu item enhancements: display toolbar and remove dropdown (#17986)
* Display toolbar and remove dropdown from menu item * Fixes block toolbar misalignment on IE. * Replace destination and deal with keypresses. * Update fixture. * Keydown management and attempt at close on blur. * Add definitive menu item icon. * Fix label/input styling. * Clean up styles after rebase. * Refactor stop propagation . * Remove duplicate dependency comments * Navigation Block: Rename 'destination' to 'url' in server-side code
Configuration menu - View commit details
-
Copy full SHA for 936ec69 - Browse repository at this point
Copy the full SHA 936ec69View commit details
Commits on Oct 28, 2019
-
Fix overlapping controls in the Inline Image formatting toolbar (#18090)
* Fix overlapping controls in the Inline Image formatting toolbar * Inline mage formatting: make Apply button same height as Width input * Polish.
Configuration menu - View commit details
-
Copy full SHA for dda7d96 - Browse repository at this point
Copy the full SHA dda7d96View commit details -
Raw handling: Fix strikethrough formatting when copy/pasting from Goo…
…gle Docs in Safari (#17187)
Configuration menu - View commit details
-
Copy full SHA for 9023ca2 - Browse repository at this point
Copy the full SHA 9023ca2View commit details -
Tutorial: Specify block naming restrictions (#18117)
* Tutorial: Specify block naming restrictions * Remove an incorrect comma
Configuration menu - View commit details
-
Copy full SHA for a6e1252 - Browse repository at this point
Copy the full SHA a6e1252View commit details -
Components: ExternalLink, add story (#18084)
This update adds a story for the ExternalLink component. Storybook knobs were added to better demonstrate the component's properties.
Configuration menu - View commit details
-
Copy full SHA for 5a88ec3 - Browse repository at this point
Copy the full SHA 5a88ec3View commit details -
Storybook: Add ColorPicker component (#18013)
* Add color picker component to Storybook * Switch screen-reader-text to new VisuallyHidden * Update ColorPicker tests snapshots * Add story for showing Alpha Channel * Move state out of exported component * Lowercase story name
Configuration menu - View commit details
-
Copy full SHA for 711f9ff - Browse repository at this point
Copy the full SHA 711f9ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for f0dc07c - Browse repository at this point
Copy the full SHA f0dc07cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a0a929 - Browse repository at this point
Copy the full SHA 3a0a929View commit details -
Configuration menu - View commit details
-
Copy full SHA for 567216f - Browse repository at this point
Copy the full SHA 567216fView commit details -
Add
DimensionControl
component (#16791)* Adds initial component Note this is copied wholescale from original PR #16730 * Remove redunant files. Refactors tests. * Updates docs * Checks callbacks are functions prior to calling * Adds temp testing example usage of component to Group Block * Updates to allow sizes as an (optionaly) prop dependency * Update default value label * Removes unnecessary InstanceId HOC usage Addresses #16791 (comment) * Remove unused abbreviation in size table * Revert "Adds temp testing example usage of component to Group Block" This reverts commit 6f9f3bf. * Remove arbitrary size value from sizes list This is not required as we cannot know how the dimensions component will be used. Therefore sticking with relative values via the slugs is safer. These can be mapped on a case by case basis as required. * Remove icon label for a11y reasons Addresses #16791 (comment) * Update component docs for consistency, spelling and grammar * Tweak docblock formats * Update test snapshots to match new default value * Update API from onSpacingChange to more agnostic onChange Addresses #16791 (comment) * Update tests to cover onChange handler renamed * Update currentSize prop to value for consistency with other components * Removes onReset in favour of onChange with undefined for consistency Adddresses #16791 (comment) * Move component to @wordpress/components package * Remove invalid font sizes style import Accidentally included from rebase. * Deps update due to rebase * Remove unneeded doc blocks * Remove usage suggestion which was not helpful * Update readme docs to match current API Addresses #16791 (comment) * Export as experimental component Addresses #16791 (comment) * Revert "Deps update due to rebase" This reverts commit 95d00f3. Addresses #16791 (comment)
Configuration menu - View commit details
-
Copy full SHA for 4f2e7f2 - Browse repository at this point
Copy the full SHA 4f2e7f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef2ecc7 - Browse repository at this point
Copy the full SHA ef2ecc7View commit details -
Configuration menu - View commit details
-
Copy full SHA for b616e28 - Browse repository at this point
Copy the full SHA b616e28View commit details -
Configuration menu - View commit details
-
Copy full SHA for b3ad226 - Browse repository at this point
Copy the full SHA b3ad226View commit details -
Configuration menu - View commit details
-
Copy full SHA for 702b11c - Browse repository at this point
Copy the full SHA 702b11cView commit details -
Commander: switch cloning method to HTTPS (#18136)
* Commander: switch cloning method to HTTPS * Add HOME env variable
Configuration menu - View commit details
-
Copy full SHA for 669da7a - Browse repository at this point
Copy the full SHA 669da7aView commit details
Commits on Oct 29, 2019
-
Add horizontal option for the block movers (#16615)
* horizontal option for the mover, missing icons, broken hover * we now have icons * positioned the mover to the middle left * horizontal mover on mobile * vertical layout for horizontal movers * drop block movers into block edit to enable inline movers * implemented so as to not be a concern for the block implementer * removes useless scss variable * hiding the drag handle at block level * renamed horizontalMover to moverOptions to incorporate separation of properties * rafactores the mover options * Initial CSS work to make the menu more manageable. This moves to flex instead of grid, neutralizes margins, simplifies a few things. * Make movers inline again. * Further improve margins for child blocks. * adds proper aliases in BlockEdit * previxed options as experimental * RTL movers * removed the position option, marked option experimental * labeled as experimental new mober and block list props * refactored direction detection code for better readability, fixed some code alignment issues
Configuration menu - View commit details
-
Copy full SHA for 2980cb9 - Browse repository at this point
Copy the full SHA 2980cb9View commit details -
Update ExternalLink Component to fix visually hidden text (#18142)
* Switch screen-reader-txt to VisuallyHidden component * Fix core embed test snapshot, new classname
Configuration menu - View commit details
-
Copy full SHA for bd8dc3b - Browse repository at this point
Copy the full SHA bd8dc3bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9158c3c - Browse repository at this point
Copy the full SHA 9158c3cView commit details -
* if thre is only one there is only one * made a new insertion point selector, some code review refactoring * better handling of inserter * refactoring and named block insertion * updates to the appender * update snapshots * update docs * default inserter label is used in so many tests * fixed allowed blocks test * snapshot updated * better naming and removed the need for es-lint disabling * improved the inserter label construction * improved the doc of getTheOnlyAllowedItem selector * reverting test patches becasue patching without understanding is bad, bad, bad - don't do it * moved getInsertionIndex out of selectos and back into each component that used it * docs generated * added experimental labels to new selectors, added es-lint comment back * updated docs * Update packages/block-editor/src/store/selectors.js Co-Authored-By: Miguel Fonseca <[email protected]> * Update packages/block-editor/src/store/selectors.js Co-Authored-By: Miguel Fonseca <[email protected]> * refactored and fixed some coding errors * small code move * small code move * removes aria attrs for autoinserted items * fixes typo, adds translators comment * simplifies the intserter logic * fix for the simplification * simplifies by using one selector and passing props in compose * small code updates * lint * renamed insertedBlock * small doc update * adds tooltip to the default button appender * refactores for more self documenting varnames
Configuration menu - View commit details
-
Copy full SHA for f56110d - Browse repository at this point
Copy the full SHA f56110dView commit details -
Components: Draggable, add story (#18070)
* Components: Add Story for Draggable This update adds a Storybook example for the Draggable component from `@wordpress/components`. * Fix useState hook for Draggable story example Solution was to create an Example component with the useState hook. Render that Example component in the story instead.
Configuration menu - View commit details
-
Copy full SHA for 876272d - Browse repository at this point
Copy the full SHA 876272dView commit details -
Block Directory: Convert it to UI Plugin to avoid bundling into Core (#…
…17576) * Block Directory: Convert it to UI Plugin to avoid bundling into Core * Load the block directory assets only when the experiment is enabled * Try to reimplement asset overrides to give more flexibility * Add code style improvemements and perform code cleanup * Try to make PHP unit tests pass by removing group check * Ensure that packages and vendor scripts are printed in the footer * Fix the has action check for the block directory assets * Move gutenberg-block-directory experiment check out of the action * Fix bin/get-vendor-scripts.php
Configuration menu - View commit details
-
Copy full SHA for e6d8284 - Browse repository at this point
Copy the full SHA e6d8284View commit details -
Configuration menu - View commit details
-
Copy full SHA for e390bf8 - Browse repository at this point
Copy the full SHA e390bf8View commit details -
Configuration menu - View commit details
-
Copy full SHA for c3ea270 - Browse repository at this point
Copy the full SHA c3ea270View commit details -
Fix columns full-wide regression. (#18021)
The Columns block, when full-wide, has intentional left and right padding to ensure the mover controls of child blocks are accessible. This is editor-only, and only when the block is selected. This regressed at some point, a while ago, probably around the introduction of extra on-click padding to show the dashed outlines of child elements. This PR shuffles the rules a bit, reduces some of their specificity, and applies the left and right padding elsewhere to make it work.
Configuration menu - View commit details
-
Copy full SHA for 3febc48 - Browse repository at this point
Copy the full SHA 3febc48View commit details -
Resyncs RichText mobile components with web counterparts. (#17897)
* Resyncs RichText mobile components with web counterparts. * Remove outdated test. * Remove unused references. * Add platform component * Add components depending of platform. Only add specific components if we are on the web implementation. * Abstract paste of files for RN and web Makes the code for pasting image more abstract in the paste method and implement specific translation to HTML depending of the platform. * Compose extra attributes/props on select/dispatch only if mobile. * Remove RN index file for RichText Wrapper. Moved all the specific code to the standard index file, so this file is no longer needed. * Remove API index native file that is no longer needed. * Clean up lint errors in file-paste-handler. * Fix lint errors. * Implement stub remove browser shortcuts for RN * Implement autocomplete stub for RN. * Refactor toolbar presentation to a method. * Remove no longer needed platform file. * Consolidate the file paste handler in a single implementation. Created a stub for createBlobURL for native that simple returns the original URL. * Change the text for platform to make it explicit it's native only. * Remove duplicate files * Include type in file comparison * Forgot to rename for native file * Fix filePasteHandler for native * Move logging back * Restore comment on logging * Add check for files existence. * Refactor format-toolbar code to use split web/native files * Remove prop duplication. * Fix getAnchorRect call * Remove unnecessary const * Sync fix for list removal of first empty line * Fix RN build after merge with master * Sync with web counterpart. * Only change selection after new formats are set.
Configuration menu - View commit details
-
Copy full SHA for 7aabe96 - Browse repository at this point
Copy the full SHA 7aabe96View commit details -
[RNMobile] Add a subtitle for unsupported blocks (#18107)
* Add a new unsupported subtitle to missing blocks - even we know about the block title * Update margins, colors and font weight of the unsupported block
Configuration menu - View commit details
-
Copy full SHA for 078b024 - Browse repository at this point
Copy the full SHA 078b024View commit details -
Navigation: Explore default frontend styles (#18094)
* try basic version of varia theme styles as default * Add class to show submenu indicator * adjustments for small viewports
Configuration menu - View commit details
-
Copy full SHA for 152cbf1 - Browse repository at this point
Copy the full SHA 152cbf1View commit details -
NavigationMenu: set attributes rightly (#18150)
* navigation-menu: set attributes once * navigation-menu: add CSS class as hook dependencies * Update packages/block-library/src/navigation-menu/edit.js Co-Authored-By: Enrique Piqueras <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 818d974 - Browse repository at this point
Copy the full SHA 818d974View commit details -
Update packages/block-editor/src/components/colors/use-colors.js (#18147
) Co-Authored-By: Enrique Piqueras <[email protected]> (+2 squashed commits) Squashed commits: [36484b4d3f] Update packages/block-editor/src/components/colors/use-colors.js Co-Authored-By: Enrique Piqueras <[email protected]> [9c4c769] Fix: solve some issues in useColors hook
Configuration menu - View commit details
-
Copy full SHA for 095c0e4 - Browse repository at this point
Copy the full SHA 095c0e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc8a136 - Browse repository at this point
Copy the full SHA bc8a136View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5eb2f23 - Browse repository at this point
Copy the full SHA 5eb2f23View commit details
Commits on Oct 30, 2019
-
Experimental Link creation interface (#17846)
* Initial component file structure * Implement basic icon and toggle mechanic * Adds basic search input * Update input to utilise LinkEditor component autocomplete * Add ability to customise placeholder * Update to utilise URLInput directly for greater flexibility * Add example search results and test coverage * Update class naming convention to match guidelines See https://github.com/WordPress/gutenberg/blob/master/docs/contributors/coding-guidelines.md#css Addresses #17846 (comment) * Adds render prop to enable custom suggestions rendering Previously it wasn’t possible to customise the render of the search suggestions. By providing an optional render prop we now have full control over this if required. * Update to utilise URLInput render prop to customise search suggestions render Previously we relied on our own render of suggestions but this wasn’t hooked up to all the accessibility enhancements afforded by URLInput. By utilising the render prop exposed by URLInput to customise the rendering of suggestions, we can have the best of both worlds. * Update to add post type to the fetchLinkSuggestions responsive mapping This is required to display the type of entitity in the search results for LinkControl * Fix to ensure search suggestion interaction states are perceivable * Update suggestion render prop to provide component props as arguments Previously when using the `renderSuggestions` render prop the user had to know how to put together the correct props on the correct elements in their custom render. By passing the default props for the listing element and the item element we can relieve the user of this burden by allowing them to spread the props onto the appropriate elements in their render without having to know how they are created. * Update to match with design visual and provide more accessible markup * Adds settings area. Fixes missing reset icon. * Fix search items to be buttons with correct style and layout * Adds overflow scrolling to search results * Fix to stop scroll shadow overlaying scrollbars * Add bespoke settings area and tweak styles * Update to allow URLs to be conditionally handled as a suggestion Previously when a URL was entered it was deemed that no suggestions should or could be found and so the process of fetching suggestions was short circuited. Add additional prop to optionally allow developers to have URL-like values handled as suggestions. * Updates to conditionally use an entity or url based search results fetcher If the current value of the input is a URL then we conditionally pass a different handler for search results to the URLInput component. For URL based values we immediately return a “suggestion” object with values matching those entered by the user. Non URL based values are handled as previously. * Fix bug whereby fetchSearchSuggestions wasn’t called Remove ambiguity by calling the search handler directly rather than proxying through another function and having to apply it immediately. * Remove default toggle UI and implement Popover close The LinkControl will be mostly where another element triggers the UI to appear. As a result we don’t want to force a toggle element on the developer. Rather we will expose an API to allow the consuming component to toggle the visibility of the LinkControl * Adds search text “highlighting” in results list * Move TextHighlight component to its own file * Fix bug where update to value prop didn’t cause suggestions to reset. * Update to remove internal handling of open/closed state This state is now expected to be handled by the consuming component chosing whether or not to render the component. It has no concept of open or closed. * Fix React violation by returning only the text for non matches * Update existing tests to match new implementation * Add link reset test * Adds test which uncovers major bug in the implementation Basically this test has revealed that due to the way we’re detecting and handling URL-like values the wrong data fetcher function gets passed to the URLInput component for the first input `change` event. For example if you paste `https://make.wordpress.com` directly into the input then it is determined to be a URL but because the current fetcher function for the current render is still the handler that deals with entity searches the correct results are not displayed. Adding another character to trigger a re-render will cause the UI to update to the expected state, but this is a major bug. * Tweak critical test to be more explicit about what is expected * Fix bug to make determining search handler use the latest input value Previously we relied on parent component state to choose which search handler to use for the current input term. However, the state was always 1 tick behind so the previous search handler got used. Updating this to use the real time value of the input passed onChange ensures we select the correct search fetcher when the component re-renders. * Add loading spinner and associated test coverage Spinner was technically always rendered but it wasn’t visible due to CSS styling. Fix and also cover with tests. * Fix bug where value could be empty * Adds basic editing / view state switching * Add keydown callback to URLInput * Select link on ENTER keydown event * Utilise LinkViewer to render edit state and decode urls for display * Only display link settings when a link is selected * Adds current link view styles * Makes settings toggle controlled by parent component * Update visuals to match updated design Addresses #17557 (comment) * Add standardised min width to popover * Temporary hack to include Link UI in Playground for testing * Update to utilise isURL util from @wordpress/url package * Update to utilise isURL util from @wordpress/url package * Removes URLPopover dependency Attempts to remove unwanted deps on other components. We now utilise Popover directly and suffer no consequences as we are not making use of any bespoke features provided by URLPopover. * Extract settings drawer to sub component * Refactor search items into a component * Refactor Input and Search to component * Fix missing selected state on search suggestions * Tweak line height on search suggestion url path * Augment test for URL-like by testing for “www.” * Fix to stop url overflows and wrapping on to multiple lines * Uppcase URL in type indicator within search results list * Avoid reading out slug/URL for entity results * Ensures i18n of change button * Always offer URL result in search suggestions as default * Fix loading spinner position and dim results during loading Addresses #17846 (comment) * Fix scroll shadows to use valid alpha transparent values in gradient Fixes broken shadows in Safari which didn’t recognise transparent as a value to transition to in a gradient. * Adds instructional text in place of URL for suggestions that are URLs Addresses designer feedback #17557 (comment) * Update prop names for consistency Addresses #17846 (comment) * Update line length to improve readability Addresses #17846 (comment) * Update to avoid need to utilise partialRight util from lodash Addresses #17846 (comment) * Updates key to avoid usage of index We cannot assume the suggestion `id` will be unique. This is because at the moment the search results are `Post`s. However in the future we may also need to include `Category` terms and the term IDs could easily clash with the Post IDs as they are in different DB tables. Using the `type` to differentiate the key. Addresses #17846 (comment) * Update to remote isFunction check in favour of direct check Addresses #17846 (comment) * Update to handle mailto and tel protocols and internal links * url-input: handle onKeyPress type event * link-control: add className prop * link-control: add README file * Remove unnecessary use of useCallback Addresses #17846 (comment) * Fix current automated tests * Improves URL handling test to run for multiple URL value variations * Updates to display the URL type in the search results Previously only true `http` URLs were formatted with the correct type and the instructional text. Fixes so that all types of manual URL entry are correctly shown as such in the search results. Adds test to cover mailto variant of this. * Refactor tests to assert against all valid protocol formats and link variants This now includes tel, mailto and internal links. * Adds test to cover display of fallback URL search result for search values that are potentially URLS * Adds tests to check URL suggestions don’t display for non-URLs. * url-input: remove unneeded `suggestion` const * url-input: always trigger onKeyDown event * link-control: delegate handling keydown event Instead of this, let's propagate the onKeyDown and onKeyPress events to the parent component * link-control: add onKeyDown and onKeyPress handlers * link-control: playground -> close once onClose * link-control: propagate onClose() event * link-control: playground -> hanldling close by ESCAPE key * Fix to only render settings draw if settings are defined * Remove redundant commented out test * Update to render with a “current link” if one is provided. Previously if you passed in a current link the component would still render with a search box as thought nothing was selected. Updates so that if `currentLink` is provided the UI reflects that by showing the “selected” item and no search input. * Render playground with currentLink active * Adds test to cover currentLink prop * Remove selected state from Playground * Adds tests to cover selecting and changing links * Remove async function in place of direct Promise usage and add test coverage * Add test to cover keyboard handling Note: this uncovered a bug whereby keyboard handling of “selecting” the link you want to use is broken. This needs to be fixed. * Remove unecessary dep from effect * Fix URLInput to pass the actual suggestion object not the index If the full object is not provided then consuming components have no way of accessing the details of the selected suggestion thereby rendering it useless. * Fix keyboard handling so hitting `ENTER` will select an item as the current link Builds on previous commit. * Updates keyboard interaction test to include URL entry * Minor: reword test description * Fix missing key prop regression Previously `buildSuggestionItemProps` was including a key. However the implementation of `LinkControl` changed so that this was not required. However we forgot to reinstate on `URLInput`. This update ensures a key prop is set on the default output. Note that disabling of the autofocus linting was already in place: https://github.com/WordPress/gutenberg/blob/04e142e9cbd06a45c4ea297ec573d389955c13be/packages/block-editor/src/components/url-input/index.js#L239 Addresses #17846 (comment) * DRY up conditionals Addresses #17846 (comment) * link-control: set a default experimental link suggestions searcher if it't needed * link-control: handling key events * url-input: remove onKeyDown prop * url-input: remove calling onKeyDown prop * url-input: rollback some changes * Mark Link Creation Interface as Experimental (#18110) * mark main component as experimental * mark new URLInput props as experimental * add experimental onKeyPress * remove key handlers * Updates to use alias on experimental props Addresses #18110 (comment) * Remove unused prop from docs * Update props ordering and readme docs Also fixes eslint errors that kept me from committing the original changes * Revert playground changes * Rename InputSearch to SearchInput Props @talldan I really hope those changes I had to make in `search-input.js` don't break anything. * Remove disabling of jsx-key lint rule * Change fake id value to something that will not clash with post ids
Configuration menu - View commit details
-
Copy full SHA for d6ce94c - Browse repository at this point
Copy the full SHA d6ce94cView commit details -
[RNMobile] Hotfix 1.15.2 (#18128)
* Force block inserter to re-render on device rotation (#18101) * Force block inserter to re-render on device rotation * Dummy * Revert "Dummy" This reverts commit 037f076. * Add left right borders to inner blocks (#18109) * [Mobile]Remove alignment options from Media & Text until they are fixed (#18112) * Remove alignment options temporarily * Dummy commit * Fix: remove getItemLayout which causes scroll position issue (#18060) * Fix: Media & Text Loses upload status if post is closed/reopened during the upload (#18137) * Prevent deleting mediaType on upload progress * Call onMediaUpdate instead of onSelectMedia * Dummy commit * Revert "Dummy commit" This reverts commit 5ce06d6. * Limit requestMediaImport calls for only image type * Update comment * Dummy commit * Revert "Dummy commit" This reverts commit 99584e4.
Configuration menu - View commit details
-
Copy full SHA for d56979d - Browse repository at this point
Copy the full SHA d56979dView commit details
Commits on Nov 1, 2019
-
Fix handling of pasted images and prevent thumbnail uploads (#18215)
* Fix handling of pasted images and prevent thumbnail uploads * Fix lint errors * Remove check for image for sync.
Configuration menu - View commit details
-
Copy full SHA for 13ba7dc - Browse repository at this point
Copy the full SHA 13ba7dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b2f0a2 - Browse repository at this point
Copy the full SHA 5b2f0a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76c9c4b - Browse repository at this point
Copy the full SHA 76c9c4bView commit details