Update: Refactor ColorPalette by extracting its design #17154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Code Quality
jorgefilipecosta
requested review from
ajitbohra,
chrisvanpatten,
gziolo,
talldan and
youknowriad
as code owners
jorgefilipecosta
force-pushed
the
update/extact-circular-option-picker-internal-component-containing-color-palette-design
branch
5 times, most recently
from
4b698cf to
ccb0f00
Compare
jorgefilipecosta
force-pushed
the
update/extact-circular-option-picker-internal-component-containing-color-palette-design
branch
from
ccb0f00 to
89d00c5
Compare
jorgefilipecosta
force-pushed
the
update/extact-circular-option-picker-internal-component-containing-color-palette-design
branch
from
89d00c5 to
1c1ebd2
Compare
jorgefilipecosta
force-pushed
the
update/extact-circular-option-picker-internal-component-containing-color-palette-design
branch
from
1c1ebd2 to
72b8a23
Compare
draganescu
approved these changes
Oct 2, 2019
|
Thank you for the review @draganescu 👍 |
youknowriad
deleted the
update/extact-circular-option-picker-internal-component-containing-color-palette-design
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extracts the design from the ColorPalette component. So ColorPalette just contains the color-related functionality and CircularOptionPicker an internal component contains the UI to render a set of buttons as circles and a set of actions at the bottom.
We are implementing a set of Gradient presents #16662 (comment) so extracting this component allows us to use the same UI for the Gradient Presets without code repetition.
Missing updates to unit tests.
How has this been tested?
I checked that the color functionality still works exactly as before.