-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a workflow to trigger CI jobs #16987
Conversation
Ok I followed the docs, but how am I supposed to test this workflow? |
I think the best way to test is having a fork, not directly pushing to the official version, then we can reference that fork here |
The problem is that the forked repo won't have access to the GitHub Actions beta. |
os: [ubuntu-latest] | ||
|
||
steps: | ||
- uses: actions/checkout@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything under steps:
needs to be indented by 2 spaces.
Looks good but I don't think that we should be replacing Travis just yet. Per the docs:
If you wanted to just try it I'd be happy for you to merge this PR, test it, and then revert the PR 😀 Something I noticed is that you can specify job dependencies so that some jobs don't run until others finish. I'd be interested to try having three jobs:
Very curious to find out if all that Microsoft money makes Actions faster than Travis! 😇 |
Very similar to Travis CI stages, but at the moment the time it takes to spin up the Docker'ish builds of ~180 seconds needs to be accounted for in the total time for a build. So, for example, if the The above times are rough guesstimates based on current CI job times. Comparing the above scenario to the current Travis CI job concurrency we have of 15 concurrent jobs for the entire Gutenberg CI build and all jobs are completed in ~15 minutes.
Actions comes with 20 concurrent jobs per repo so if the CPU and Memory outperform Travis CI and/or the current test jobs be further split to utilize the extra 5 concurrent jobs CI build time may be reduced without having to use job dependencies (stages). |
it seems that for some reason, Action flooded my email with notifications, about 5 for a single PR #16982, not sure why just this PR and not other ones (I have other PRs after it) and why 5. |
@senadir Yep, I updated Gutenberg to use the new version of actions today and this happened. It looks like you can change your notifications in github's settings: |
I think I'm going to close this PR because I don't have enough time to push it forward. Feel free to take over. |
Try adding a workflow to see if it can be a replacement for travis.