Fix: Block paddings on the widget screen. #16944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Feature] Widgets Screen
youknowriad
reviewed
Aug 8, 2019
| // By default the default block appender inserter has a negative position, | ||
| // but given that on the widget screen we have 0 padding we need to remove the negative position. | ||
| .block-editor-default-block-appender .block-editor-inserter, | ||
| .block-editor-block-list__empty-block-inserter { |
There was a problem hiding this comment.
I think these can be nested, do we want that config for all the nested appenders?
There was a problem hiding this comment.
Hi @youknowriad, nested appenders have a CSS rule with much higher specificity that overwrites this value. Ther value was already different between the top-level appenders and nested ones in the edit-post.
jorgefilipecosta
force-pushed
the
fix/block-paddings-on-the-widget-screen
branch
from
f79f7ec to
48251de
Compare
|
The width seems ok. I'd appreciate a check from @mapk I noticed that the blocks are too "condensed" (there's no margins between them). Probably unrelated with this PR but should we apply the same margins as we do in the content editor. |
|
Just checked, and it looks much better now! Thanks! Example:
|
youknowriad
approved these changes
Aug 10, 2019
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #16600
This PR increases the width of the block widgets areas and reduces the padding to make blocks have a bigger space.
How has this been tested?
I enabled the experimental widgets screen on the settings page.
I went to the widgets screen.
I verified the content width is bigger and the padding is lower (when compared to the master).