Docs: Add section about adding new dependencies to WordPress packages #16876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Developer Documentation
chrisvanpatten
suggested changes
Aug 3, 2019
Co-Authored-By: Chris Van Patten <[email protected]>
They should hire you at Grammarly to improve their system which catches grammar issues, thanks for all corrections. 😄 |
gziolo
added a commit
that referenced
this pull request
Aug 29, 2019
…#16876) * Docs: Add section about adding new dependencies to WordPress packages * Apply suggestions from code review Co-Authored-By: Chris Van Patten <[email protected]>
gziolo
added a commit
that referenced
this pull request
Aug 29, 2019
…#16876) * Docs: Add section about adding new dependencies to WordPress packages * Apply suggestions from code review Co-Authored-By: Chris Van Patten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a section about adding new dependencies to WordPress packages. See new section's preview:
https://github.com/WordPress/gutenberg/blob/a300ed9530b7b4746924194b75117678e3592cc7/packages/README.md#adding-new-dependencies
I came up to the conclusion that this needs to be explained explicitly after talking to @dsifford. He had some issues when he wanted to add a new dependency to one of the packages. I hope all the proposed changes will make it easier for future contributors.