-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose BlockPreview component #16834
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
823b006
to
5dfe9a0
Compare
097bc0f
to
3251ebd
Compare
b354d9f
to
ac56950
Compare
Changed target to |
0d1aecf
to
ba9d181
Compare
Rebased and updated readme to reflect current props — only |
youknowriad
reviewed
Aug 2, 2019
youknowriad
approved these changes
Aug 2, 2019
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
* block-editor: expose BlockPreview block * block-preview: add README file. props to @jasmussen and @getdate * match readme with current functionality * move doc comment so it is picked up by the generator
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
* block-editor: expose BlockPreview block * block-preview: add README file. props to @jasmussen and @getdate * match readme with current functionality * move doc comment so it is picked up by the generator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR exposes the
BlockPreview
component in order to make it available to be consumed by other plugins.This branch has been created from
update/unify-block-preview-components
How has this been tested?
A simple way to confirm whether the function is being exposed is trying to get it from the console of your dev browser. Type
wp.blockEditor
and look up theBlockPreview
among the other components. Without these changes, theBlockPreview
shouldn't be there.Types of changes
Expose the
BlockPreview
component.Checklist: