Components: Avoid displaying tooltip on focus from mousedown #16800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Type] Bug
aduth
requested review from
ajitbohra,
chrisvanpatten,
gziolo,
jorgefilipecosta,
talldan and
youknowriad
as code owners
|
It looks like this change invalidated several snapshots saved for unit tests: I guess |
mtias
reviewed
Jul 30, 2019
| @@ -35,13 +35,29 @@ class Tooltip extends Component { | |||
| TOOLTIP_DELAY | |||
| ); | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Should this be just a multiline comment with //?
There was a problem hiding this comment.
Should this be just a multiline comment with
//?
It's meant to be JSDoc describing the instance variable. I guess including @type (like in the subsequent one) could help make this clearer).
Thanks. Updated in 3363cb6. |
gziolo
approved these changes
Jul 30, 2019
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
* Components: Avoid displaying tooltip on focus from mousedown * Testing: Update Tooltip snapshots * Components: Tooltip: Add JSDoc type for assigned cancelIsMouseDown
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
* Components: Avoid displaying tooltip on focus from mousedown * Testing: Update Tooltip snapshots * Components: Tooltip: Add JSDoc type for assigned cancelIsMouseDown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to resolve an issue where a button with an associated tooltip will briefly flash the tooltip when clicked. The underlying issue here is that a tooltip is expected to be shown (immediately) when a button is focused. Previously, this was not disambiguated from focus which results from clicking to interact with the button, where the tooltip is not expected to be shown.
Testing instructions:
Verify there are no regressions in the display of the tooltips being shown upon focusing the button.
Verify that the tooltip is not shown when clicking on a button with an associated tooltip (e.g. inserter, block movers, etc).
Needs Accessibility Feedback: I'd appreciate any advice on whether I've overlooked any use cases with the assumption that focus-via-click should be ignored.